[SS-JIA]

Stack from ghstack (oldest at bottom):

• [ET-VK][ops] Consolidate binary scalar shaders behind op_type #24756
• [ET-VK][runtime] Preserve binary and permute zero padding #24755
• [ET-VK][runtime] Preserve zero padding in unary operators #24754
• [ET-VK][runtime] Align buffer packed dimensions to four #24753
• -> [ET-VK][ops] Pass op_type to unary and binary op helpers #24752

Ulterior Motive

Prepare the unary and binary op helpers for fused ops, which may apply more
than one op and so have no single op_type specialization constant.

Rationale

What: apply_unary_op and apply_binary_op take the op type as their
first argument instead of reading the including shader's op_type
specialization constant.

Why: A fused shader can then pass a different op type to each call.

Details

• apply_unary_op / apply_binary_op

  • Before: apply_unary_op(X, A, B) and apply_binary_op(X, Y, A) read
    the global op_type, so every including shader had to declare it.

  • After: apply_unary_op(op_type, X, A, B) and
    apply_binary_op(op_type, X, Y, A). Existing shaders pass their
    op_type specialization constant, so drivers still fold the switch.

    // Fused binary + unary, each op selected independently
    vec4 sum = apply_binary_op(binary_op_type, a, b, alpha);
    vec4 out_texel = apply_unary_op(UNARY_OP_RELU, sum, 0.0, 0.0);

Authored with Claude Code.

Differential Revision: D130297301

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24752

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 4 Pending, 2 Unrelated Failures

As of commit 43ee7e4 with merge base 9517b6b ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Test Vulkan Backend (specialized runners) / test-model-vulkan-e2e / linux-job (gh) (trunk failure)
  RuntimeError: Command bash /__w/_temp/exec_script failed with exit code 1
• Test Vulkan Backend (specialized runners) / test-vulkan-nvidia / linux-job (gh) (trunk failure)
  RuntimeError: Command bash /__w/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.