Repository navigation
Preserve callable factory return types in hashlib.file_digest - #16508
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Oct 12, 2026
| algorithms_guaranteed: AbstractSet[str] | ||
| algorithms_available: AbstractSet[str] | ||
|
|
||
| _T = TypeVar("_T", bound=_HashObject) |
Collaborator
There was a problem hiding this comment.
Let's use a name other than _T, which is often used to indicate an unbound type var. Maybe _HashT? Also please move it to the top before def new.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callable factories for
hashlib.file_digest()retain their own type at runtime, but the stub currently returnsHASHfor factories producinghmac.HMACorblake2b.Separate the string and callable overloads to preserve the factory return type, matching the documented HMAC example.
Agent used: Codex (GPT-6.1-sol) for investigation, implementation, and verification.