Repository navigation
Abstract methods in non-abstract imporlib.metadata.Distribution #419
Description
Activity
I can't remember if there was a reason why I chose not to configure the metaclass. Perhaps I thought it was optional. Thanks for the reference to the documentation, as it clarifies that ABCMeta should be used unconditionally if abstract methods are present.
Also, thanks for the PR, which illustrates that simply configuring the meta class isn't viable, because downstream consumers are depending on the non-enforcement of the interface, making introduction of the enforcement a backward-incompatible change.
I'll have to think about it more and determine if there's a path forward here and if so how. I'd like the test suite to include a test capturing the enhanced expectation here. It's also likely that this issue should be addressed first in
importlib_metadata, which can iterate faster and get feedback on any approach sooner.But before we embark on a solution, what is the importance of this issue? Is the goal mainly to align best practices or do you have a more concrete goal in mind?
I have encountered the issue when I was studying importlib.metatdata. So for me personally, I was just little bit confused by methods having abstractmethod, but the class not having metaclass=abc.ABCMeta.
So only goal was to clarify the confusion, why there are abstract decorated methods where the decorater has no effect.
why there are abstract decorated methods where the decorater has no effect.
This can be useful for type-checking purposes. While at runtime, the decorator only has an effect if the metaclass is
ABCMetaor a subclass ofABCMeta, mypy respects the@abstractmethoddecorator even if the metaclass is notABCMetaor a subclass ofABCMeta. (That's a mypy feature, not a mypy bug, FYI.)Decorating methods with
@abstractmethodcan also serve as useful documentation about the methods' intended purpose, even if the metaclass is not set.Thank @AlexWaygood for the information about mypy checking
@abstractmethoddecorated methods.If this use of the decorator is a good practice, then I am happy with the resolution.
In pypa/pip#11684, I reported the issue to pip so the usage can be corrected there, paving the way to potentially introduce the ABCMeta. In the meantime, it's probably safe to add the change to importlib_metadata to see if there are potentially other uses out there (seems unlikely). I'll transfer this issue to that project.
- added a commit that references this issue
on Dec 26, 2023
The empty methods read_text and locatate_file of Distribution class are decorated with abc.abstractmethod. But Distribution class doesn't have metaclass=abc.ABCMeta.
PEP 3119, Introducing Abstract Base Classes, states.:
Considering the facts that methods read_text and locate_file are used in other methods of Distribution class and both are empty, only things containing are docstrings, I think the author of the class intended to use the abstractmethod functionality to enforce an implementation of the aforementioned methods. So, in my opinion, the Distribution class should have metaclass=abc.ABCMeta.
(Other possibility is that the aforementioned methods are intended as stubs. Then the abstractmethod decorator may be deleted.)
I've created the PR in case the issue is right, i.e. the class should contain metaclass=abc.ABCMeta.
Linked PRs