Repository navigation
bpo-45953: Statically initialize the small ints. - #30092
Merged
ericsnowcurrently merged 12 commits intoDec 14, 2021
Merged
Conversation
ericsnowcurrently
requested review from
markshannon
and removed request for
a team
December 13, 2021 20:44
gvanrossum
approved these changes
Dec 13, 2021
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LGTM. I have a nit in a comment but it was present in the original before the move as well.
ericsnowcurrently
force-pushed
the
global-objects-small-ints
branch
from
December 13, 2021 22:20
a20f308 to
8f10ad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array of small
PyLongobjects has been statically declared. Here I also statically initialize them. Consequently they are no longer initialized dynamically during runtime init.I've also moved them under a new sub-struct in
_PyRuntimeState, in preparation for static allocation and initialization of other global objects.FWIW, I considered adding a script for generating the array initializer, but figured that can be done separately if valuable.
https://bugs.python.org/issue45953