Repository navigation
Create modular packages for zipfile and test_zipfile #98098
Description
Activity
I tried moving most of
zipfile.pytozipfile/_core.pybut that caused problems with all of the global constants in that file, many of which are treated as mutable (at least for tests).- added 4 commits that reference this issue
on Nov 26, 2022 Looks like this can be closed, but not touching it since I see it was assigned to Yhg1s and I don't know what that means
Hello, looks like this issue has lead to warning
<frozen runpy>:128: RuntimeWarning: 'zipfile.__main__' found in sys.modules after import of package 'zipfile', but prior to execution of 'zipfile.__main__'; this may result in unpredictable behaviourwhen using https://docs.python.org/3/library/zipfile.html#command-line-interfaceplease file a new issue if you believe there is a bug with instructions for how to reproduce it.
I'm about to embark on once again syncing changes from zipp to
zipfile.Historically, I've manually copied the contents of the cpython branch to the relevant files in this repository, but that process is error prone (because it involves syncing a whole file to a portion of another file).
I'd like to instead create packages for
zipfileandtest_zipfile, such that the functionality that's synced withzippcan be kept separate from other zipfile functionality. Moreover, late versions ofzippbring in extra dependencies so a package can also serve as a home to vendor such functionality.I'm not suggesting to change the user's signature at all. The names will still be presented through the
zipfilemodule unchanged.Linked PRs