Repository navigation
Add C API for importing an attribute from a module #93741
Description
It is common (more than 30 cases) in the C code to access a function or a variable from other module. For example:
functools = PyImport_ImportModule("functools");
if (!functools)
goto error;
st->partial = PyObject_GetAttrString(functools, "partial");
Py_CLEAR(functools);I propose to add a private helper function which combines PyImport_ImportModule() and PyObject_GetAttrString().
st->partial = _PyImport_GetModuleAttrString("functools", "partial");It will save 4-6 lines of code and a variable on every use.
Activity
pythongh-93741: Add private C API _PyImport_GetModuleAttrString()
kumaraditya303 commentedon Jun 13, 2022
Since this will be private API, how about using statically allocated string identifiers to avoid memory allocations?
serhiy-storchaka commentedon Jun 13, 2022
The PR adds also function
_PyImport_GetModuleAttr()which takesPyObject*arguments. You can use it with statically allocated string identifiers.gh-93741: Add private C API _PyImport_GetModuleAttrString() (GH-93742)
[3.11] pythongh-93741: Add private C API _PyImport_GetModuleAttrStrin…
[3.11] gh-93741: Add private C API _PyImport_GetModuleAttrString() (G…
[3.11] pythongh-93741: Add private C API _PyImport_GetModuleAttrStrin…
[3.11] gh-93741: Add private C API _PyImport_GetModuleAttrString() (G…
Revert 30935 defer bpo45162 to 312 (#94285)