Repository navigation
Argument Clinic doesn't mangle conflicting names #68395
Description
| BPO | 24207 |
|---|---|
| Nosy | @larryhastings, @serhiy-storchaka |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2015-05-16.10:21:03.935>
labels = ['type-bug', 'expert-argument-clinic']
title = "Argument Clinic doesn't mangle conflicting names"
updated_at = <Date 2015-05-16.10:21:03.935>
user = 'https://github.com/serhiy-storchaka'bugs.python.org fields:
activity = <Date 2015-05-16.10:21:03.935>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Argument Clinic']
creation = <Date 2015-05-16.10:21:03.935>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 24207
keywords = []
message_count = 1.0
messages = ['243304']
nosy_count = 2.0
nosy_names = ['larry', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24207'
versions = ['Python 3.5']
Activity
serhiy-storchaka commentedon May 16, 2015
Argument Clinic adds the "_value" suffix to the end of variable names in C if the parameter name is C keyword. But it left unmodified parameter names that can conflict with parameter names of C function: args and kwargs (and module and self if they are used not as the first parameter). Following declaration generates a code that can't bi compiled:
mod.func
Either Argument Clinic should add the "_value" suffix to the end of these names, or use other names for parameters of generated parser function.
erlend-aasland commentedon May 1, 2023
argsis already mangled as__clinic_args. We should also manglekwnames, since that is sometimes used instead ofkwargs(for example, for METH_FASTCALL | METH_KEYWORDS).pythongh-68395: Avoid naming conflicts by mangling variable names in …
pythongh-68395: Avoid naming conflicts by mangling variable names in …
erlend-aasland commentedon May 5, 2023
FTR, AC complains if you try to use parameters named
self(for methods) ormodule(for functions), so we don't need to special case those two.Example failure if I try to add a param named "self" to
sqlite3.Connection.__init__:gh-68395: Avoid naming conflicts by mangling variable names in Argume…
Merge branch 'main' into inlinecomp2
pythongh-68395: Avoid naming conflicts by mangling variable names in …