Repository navigation
Add a C API to assign a new version to a PyTypeObject #103091
Description
Feature or enhancement
I would like to add an API function like this:
/* Attempt to assign a version tag to the given type.
*
* Returns 1 if the type already had a valid version tag or a new one was
* assigned, or 0 if a new tag could not be assigned.
*/
PyAPI_FUNC(int) _PyType_AssignVersionTag(PyTypeObject* type);
It would be a thin wrapper around the existing assign_version_tag function, and is modeled after a similar function we added to Cinder as part of facebookincubator/MetaPython@43c4e2d.
Pitch
Cinder (and possibly other JITs or optimizing interpreters) would benefit from being able to ensure that type has a valid version tag without having to call _PyType_Lookup() just for the version-assigning side-effect. We rely on notifications from PyType_Modified() to invalidate code in our JIT when types change, and this only works when the types in question have valid version tags.
Previous discussion
There's no written discussion I'm aware of, but @carljm and @markshannon have discussed this offline.
Activity
pythongh-103091: Add PyType_AssignVersionTag
pythongh-103091: Add PyType_AssignVersionTag
encukou commentedon Mar 31, 2023
AFAIK, version tags are an implementation detail. For anything except JITs/optimizers,
PyType_Modified()should be enough API.IMO it would make sense to put this function in the unstable API. Name the function
PyUnstable_Type_AssignVersionTagto do that.carljm commentedon Mar 31, 2023
I suspect it would also make more sense for the declaration to live in
Include/cpython/object.hrather thanInclude/object.h, though I guess this isn't strictly required?gh-103091: Add PyUnstable_Type_AssignVersionTag (#103095)
Merge branch 'main' into superopt
Merge branch 'superopt' into superopt_spec
swtaarrs commentedon Apr 25, 2023
#103095 is merged. Thanks @encukou and @carljm!
brandtbucher commentedon Jun 21, 2023
I was just bit by this API's somewhat odd return value. Typically we return 0 on success and -1 on failure, but this returns 1 on success and 0 on failure.
Perhaps it should be changed?
carljm commentedon Jun 21, 2023
I'm glad you're finding uses for this API :)
The PR to expose this function outside
typeobject.cjust passed through the existing return value convention from the pre-existing staticassign_version_tagfunction, which has been there for a long time; I don't think changing it was ever considered.I'm not sure how consistent the convention is; e.g. the compiler always returns 0 on failure and 1 on success.(EDIT: never mind, looks like this was changed in #100010!) Also,-1often signifies "exception is set," but this API never sets an exception, it's just indicating whether a version tag was successfully set.No strong feelings here.
erlend-aasland commentedon Jun 21, 2023
What if we need to change the implementation in the future (because of runtime changes or whatever) and we end up having to use an internal API that can set an exception? If we design this API to always succeed, we have two options: swallow the exception before returning, or add a new API that can return with an exception set. See also the issue about infallible APIs in the C API workgroup repo.
encukou commentedon Jun 22, 2023
There's some discussion general guidelines starting over at #105201 (comment)
IMO, 0 and 1 is consistent with the direction of that discussion:
That's a valid concern -- adding an error case to an existing function, while trying to keep API compatibility, is very messy.
On the one hand this is unstable API, where we can just remove the function & replace it with a new one.
On the other hand, it's not that hard to do: put a note in the docs that it "returns -1 with an exception set" on error, and require that callers do error checking -- even though the exception currently never happens.
carljm commentedon Jun 22, 2023
This makes sense in general, but I wonder if there is still room, particularly for an explicitly unstable API, for deeming the likelihood that an API will ever need to raise an exception so low that the practical cost-benefit analysis does not favor making every caller add an extra case for handling something that is currently impossible and probably will never happen in the future, either. Of course anything is possible in the future, but for an unstable API in the unlikely scenario we have the option of just replacing the API.
Assigning a version tag to a type is a low-level internal operation (the target audience for its exposure is really only implementers of third-party runtime optimizers / JITs), and a relatively simple one, and I think we would go to some lengths to ensure that it remains simple and doesn't set exceptions in the future.
encukou commentedon Jun 22, 2023
Yup, it's totally fine for unstable API, where you can just yank the function. But it should be an informed decision.
markshannon commentedon Jun 22, 2023
This should never set an exception.
Since it can fail (returning 0) and failure doesn't indicate an error, we can just avoid code paths that can raise.