Repository navigation
Make Travis CI (and Windows x64 ?) mandatory #365
Description
Azure Pipelines CI was made optional by @brettcannon: https://bugs.python.org/issue39837
Problem: now, there is no more mandatory CI on Python pull requests. It became possible to merge a PR even if all CIs fail.
I would prefer to also have the Windows 64-bit CI (GitHub Action) mandatory, but I'm not sure if it's possible to only make a single GitHub Action mandatory?
Activity
[-]Make Travis CI mandatory[/-][+]Make Travis CI (and Windows x64 ?) mandatory[/+]Mariatta commentedon Apr 30, 2020
I can make the change. Which CI should be required, and is this the same for all branches? 3.5, 3.6, 3.7, 3.8?
Mariatta commentedon Apr 30, 2020
These are the availble CIs which I can make as "Required". Just let me know which ones we need, then i'll activate them:
Azure Pipelines CI
Azure Pipelines PR
Docs
Ubuntu
Ubuntu (C Coverage)
Ubuntu (Coverage)
Windows (x64)
Windows (x86)
bedevere/issue-numberRequired
bedevere/maintenance-branch-pr
bedevere/newsRequired
buildbot/AMD64 Arch Linux TraceRefs 3.7
buildbot/AMD64 Arch Linux TraceRefs 3.8
buildbot/AMD64 Arch Linux TraceRefs 3.x
buildbot/AMD64 Arch Linux TraceRefs PR
buildbot/AMD64 Debian PGO 3.7
buildbot/AMD64 Debian PGO 3.8
buildbot/AMD64 Debian PGO 3.x
buildbot/AMD64 Debian PGO PR
buildbot/AMD64 Debian root 3.7
buildbot/AMD64 Debian root 3.8
buildbot/AMD64 Debian root 3.x
buildbot/AMD64 Debian root PR
buildbot/AMD64 Fedora Stable 3.7
buildbot/AMD64 Fedora Stable 3.8
buildbot/AMD64 Fedora Stable 3.x
buildbot/AMD64 Fedora Stable Clang 3.7
buildbot/AMD64 Fedora Stable Clang 3.8
buildbot/AMD64 Fedora Stable Clang 3.x
buildbot/AMD64 Fedora Stable Clang Installed 3.7
buildbot/AMD64 Fedora Stable Clang Installed 3.8
buildbot/AMD64 Fedora Stable Clang Installed 3.x
buildbot/AMD64 Fedora Stable Clang Installed PR
buildbot/AMD64 Fedora Stable Clang PR
buildbot/AMD64 Fedora Stable LTO + PGO 3.7
buildbot/AMD64 Fedora Stable LTO + PGO 3.8
buildbot/AMD64 Fedora Stable LTO + PGO 3.x
buildbot/AMD64 Fedora Stable LTO + PGO PR
buildbot/AMD64 Fedora Stable LTO 3.7
buildbot/AMD64 Fedora Stable LTO 3.8
buildbot/AMD64 Fedora Stable LTO 3.x
buildbot/AMD64 Fedora Stable LTO PR
buildbot/AMD64 Fedora Stable PR
buildbot/AMD64 Fedora Stable Refleaks PR
buildbot/AMD64 FreeBSD Non-Debug 3.7
buildbot/AMD64 FreeBSD Non-Debug 3.8
buildbot/AMD64 FreeBSD Non-Debug 3.x
buildbot/AMD64 FreeBSD Non-Debug PR
buildbot/AMD64 FreeBSD Shared 3.7
buildbot/AMD64 FreeBSD Shared 3.8
buildbot/AMD64 FreeBSD Shared 3.x
buildbot/AMD64 FreeBSD Shared PR
buildbot/AMD64 RHEL7 3.7
buildbot/AMD64 RHEL7 3.8
buildbot/AMD64 RHEL7 3.x
buildbot/AMD64 RHEL7 LTO + PGO 3.7
buildbot/AMD64 RHEL7 LTO + PGO 3.8
buildbot/AMD64 RHEL7 LTO + PGO 3.x
buildbot/AMD64 RHEL7 LTO + PGO PR
buildbot/AMD64 RHEL7 LTO 3.7
buildbot/AMD64 RHEL7 LTO 3.8
buildbot/AMD64 RHEL7 LTO 3.x
buildbot/AMD64 RHEL7 LTO PR
buildbot/AMD64 RHEL7 PR
buildbot/AMD64 RHEL7 Refleaks PR
buildbot/AMD64 RHEL8 3.7
buildbot/AMD64 RHEL8 3.8
buildbot/AMD64 RHEL8 3.x
buildbot/AMD64 RHEL8 LTO + PGO 3.7
buildbot/AMD64 RHEL8 LTO + PGO 3.8
buildbot/AMD64 RHEL8 LTO + PGO 3.x
buildbot/AMD64 RHEL8 LTO + PGO PR
buildbot/AMD64 RHEL8 LTO 3.7
buildbot/AMD64 RHEL8 LTO 3.8
buildbot/AMD64 RHEL8 LTO 3.x
buildbot/AMD64 RHEL8 LTO PR
buildbot/AMD64 RHEL8 PR
buildbot/AMD64 RHEL8 Refleaks PR
buildbot/AMD64 Ubuntu Shared 3.7
buildbot/AMD64 Ubuntu Shared 3.8
buildbot/AMD64 Ubuntu Shared 3.x
buildbot/AMD64 Ubuntu Shared PR
buildbot/AMD64 Windows10 3.7
buildbot/AMD64 Windows10 3.8
buildbot/AMD64 Windows10 3.x
buildbot/AMD64 Windows10 PR
buildbot/AMD64 Windows7 SP1 3.7
buildbot/AMD64 Windows7 SP1 3.8
buildbot/AMD64 Windows8.1 Non-Debug 3.7
buildbot/AMD64 Windows8.1 Non-Debug 3.8
buildbot/AMD64 Windows8.1 Non-Debug 3.x
buildbot/AMD64 Windows8.1 Non-Debug PR
buildbot/AMD64 Windows8.1 Refleaks PR
buildbot/PPC64 Fedora 3.7
buildbot/PPC64 Fedora 3.8
buildbot/PPC64 Fedora 3.x
buildbot/PPC64 Fedora PR
buildbot/PPC64LE Fedora Stable 3.7
buildbot/PPC64LE Fedora Stable 3.8
buildbot/PPC64LE Fedora Stable 3.x
buildbot/PPC64LE Fedora Stable Clang 3.7
buildbot/PPC64LE Fedora Stable Clang 3.8
buildbot/PPC64LE Fedora Stable Clang 3.x
buildbot/PPC64LE Fedora Stable Clang Installed 3.7
buildbot/PPC64LE Fedora Stable Clang Installed 3.8
buildbot/PPC64LE Fedora Stable Clang Installed 3.x
buildbot/PPC64LE Fedora Stable Clang Installed PR
buildbot/PPC64LE Fedora Stable Clang PR
buildbot/PPC64LE Fedora Stable LTO + PGO 3.7
buildbot/PPC64LE Fedora Stable LTO + PGO 3.8
buildbot/PPC64LE Fedora Stable LTO + PGO 3.x
buildbot/PPC64LE Fedora Stable LTO + PGO PR
buildbot/PPC64LE Fedora Stable LTO 3.7
buildbot/PPC64LE Fedora Stable LTO 3.8
buildbot/PPC64LE Fedora Stable LTO 3.x
buildbot/PPC64LE Fedora Stable LTO PR
buildbot/PPC64LE Fedora Stable PR
buildbot/PPC64LE Fedora Stable Refleaks PR
buildbot/PPC64LE RHEL7 3.7
buildbot/PPC64LE RHEL7 3.8
buildbot/PPC64LE RHEL7 3.x
buildbot/PPC64LE RHEL7 LTO + PGO 3.7
buildbot/PPC64LE RHEL7 LTO + PGO 3.8
buildbot/PPC64LE RHEL7 LTO + PGO 3.x
buildbot/PPC64LE RHEL7 LTO + PGO PR
buildbot/PPC64LE RHEL7 LTO 3.7
buildbot/PPC64LE RHEL7 LTO 3.8
buildbot/PPC64LE RHEL7 LTO 3.x
buildbot/PPC64LE RHEL7 LTO PR
buildbot/PPC64LE RHEL7 PR
buildbot/PPC64LE RHEL7 Refleaks PR
buildbot/PPC64LE RHEL8 3.7
buildbot/PPC64LE RHEL8 3.8
buildbot/PPC64LE RHEL8 3.x
buildbot/PPC64LE RHEL8 LTO + PGO 3.7
buildbot/PPC64LE RHEL8 LTO + PGO 3.8
buildbot/PPC64LE RHEL8 LTO + PGO 3.x
buildbot/PPC64LE RHEL8 LTO + PGO PR
buildbot/PPC64LE RHEL8 LTO 3.7
buildbot/PPC64LE RHEL8 LTO 3.8
buildbot/PPC64LE RHEL8 LTO 3.x
buildbot/PPC64LE RHEL8 LTO PR
buildbot/PPC64LE RHEL8 PR
buildbot/PPC64LE RHEL8 Refleaks PR
buildbot/aarch64 Fedora Stable 3.7
buildbot/aarch64 Fedora Stable 3.8
buildbot/aarch64 Fedora Stable 3.x
buildbot/aarch64 Fedora Stable PR
buildbot/aarch64 RHEL7 3.7
buildbot/aarch64 RHEL7 3.8
buildbot/aarch64 RHEL7 3.x
buildbot/aarch64 RHEL7 PR
buildbot/aarch64 RHEL8 3.7
buildbot/aarch64 RHEL8 3.8
buildbot/aarch64 RHEL8 3.x
buildbot/aarch64 RHEL8 PR
buildbot/s390x Debian 3.7
buildbot/s390x Debian 3.8
buildbot/s390x Debian 3.x
buildbot/s390x Debian PR
buildbot/s390x Fedora 3.7
buildbot/s390x Fedora 3.8
buildbot/s390x Fedora 3.x
buildbot/s390x Fedora Clang 3.7
buildbot/s390x Fedora Clang 3.8
buildbot/s390x Fedora Clang 3.x
buildbot/s390x Fedora Clang Installed 3.7
buildbot/s390x Fedora Clang Installed 3.8
buildbot/s390x Fedora Clang Installed 3.x
buildbot/s390x Fedora Clang Installed PR
buildbot/s390x Fedora Clang PR
buildbot/s390x Fedora LTO + PGO 3.7
buildbot/s390x Fedora LTO + PGO 3.8
buildbot/s390x Fedora LTO + PGO 3.x
buildbot/s390x Fedora LTO + PGO PR
buildbot/s390x Fedora LTO 3.7
buildbot/s390x Fedora LTO 3.8
buildbot/s390x Fedora LTO 3.x
buildbot/s390x Fedora LTO PR
buildbot/s390x Fedora PR
buildbot/s390x Fedora Refleaks PR
buildbot/s390x RHEL7 3.7
buildbot/s390x RHEL7 3.8
buildbot/s390x RHEL7 3.x
buildbot/s390x RHEL7 LTO + PGO 3.7
buildbot/s390x RHEL7 LTO + PGO 3.8
buildbot/s390x RHEL7 LTO + PGO 3.x
buildbot/s390x RHEL7 LTO + PGO PR
buildbot/s390x RHEL7 LTO 3.7
buildbot/s390x RHEL7 LTO 3.8
buildbot/s390x RHEL7 LTO 3.x
buildbot/s390x RHEL7 LTO PR
buildbot/s390x RHEL7 PR
buildbot/s390x RHEL7 Refleaks PR
buildbot/s390x RHEL8 3.7
buildbot/s390x RHEL8 3.8
buildbot/s390x RHEL8 3.x
buildbot/s390x RHEL8 LTO + PGO 3.7
buildbot/s390x RHEL8 LTO + PGO 3.8
buildbot/s390x RHEL8 LTO + PGO 3.x
buildbot/s390x RHEL8 LTO + PGO PR
buildbot/s390x RHEL8 LTO 3.7
buildbot/s390x RHEL8 LTO 3.8
buildbot/s390x RHEL8 LTO 3.x
buildbot/s390x RHEL8 LTO PR
buildbot/s390x RHEL8 PR
buildbot/s390x RHEL8 Refleaks PR
buildbot/s390x SLES 3.7
buildbot/s390x SLES 3.8
buildbot/s390x SLES 3.x
buildbot/s390x SLES PR
buildbot/x86 Gentoo Installed with X 3.7
buildbot/x86 Gentoo Installed with X 3.8
buildbot/x86 Gentoo Installed with X 3.x
buildbot/x86 Gentoo Installed with X PR
buildbot/x86 Gentoo Non-Debug with X 3.7
buildbot/x86 Gentoo Non-Debug with X 3.8
buildbot/x86 Gentoo Non-Debug with X 3.x
buildbot/x86 Gentoo Non-Debug with X PR
buildbot/x86 Gentoo Refleaks PR
buildbot/x86 Windows7 3.7
buildbot/x86 Windows7 3.8
buildbot/x86-64 macOS 3.7
buildbot/x86-64 macOS 3.8
buildbot/x86-64 macOS 3.x
buildbot/x86-64 macOS PR
continuous-integration/travis-ci
macOS
vstinner commentedon Apr 30, 2020
It would be nice to have a least one Linux mandatory CI and one Windows mandatory CI:
It can be the same on 3.7, 3.8 and master branches.
--
For 3.5 and 3.6, only Travis CI should be mandatory.
I don't think that we have GH actions on the 3.5 branch. Example on my 3.5 PR: python/cpython#19305 there is only Travis CI there.
Same for 3.6: I only see Travis CI on this 3.6 PR: python/cpython#19224
vstinner commentedon Apr 30, 2020
In your list, I'm talking about:
Mariatta commentedon Apr 30, 2020
It's done.
continuous-integration/travis-ciandWindows (x64)are now required inmaster,3.8,3.7.continuous-integration/travis-ciis required in3.5and3.6.vstinner commentedon Apr 30, 2020
Great, thank you!
zooba commentedon Apr 30, 2020
Unfortunately, you can't make the GitHub Actions checks required, because GitHub can't tell the difference between when they are excluded by path filters (see python/cpython#19806)
I'm pinging my contacts there again, but we're going to have to only require Linux tests for now.
zooba commentedon Apr 30, 2020
(FWIW, @Mariatta, since you weren't involved in the other discussions, there isn't anyone else supportive of this change that I'm aware of - it's only Victor. But since he's not going to stop his campaign against network flakiness, I'll concede - but NOT in a way that prevents people from merging doc-only changes!)
vstinner commentedon Apr 30, 2020
Me:
@zooba:
Oh right, now I recall the issue :-/ https://bugs.python.org/issue39837#msg363405
vstinner commentedon Apr 30, 2020
I moved the discussion to the Core Workflow category of Discourse:
https://discuss.python.org/t/make-one-windows-ci-job-mandatory/4047
--
@Mariatta: Sorry, would you mind to make the Windows (64 bit) job non-voting again, until https://discuss.python.org/t/make-one-windows-ci-job-mandatory/4047 issue is resolved?
Mariatta commentedon Apr 30, 2020
Windows(64) has been made not required.
vstinner commentedon Apr 30, 2020
Thanks again.
vstinner commentedon May 14, 2020
I fixed the Windows job of GitHub Action and proposed #368 to make it mandatory.
cjerdonek commentedon May 15, 2020
FYI, I created a PR that updates only the ACKS file, and the required Travis CI never starts:
python/cpython#20105
It just stays on, "Expected — Waiting for status to be reported." Does someone know why that is happening or what I can do to skip it or get it to run?
Mariatta commentedon May 15, 2020
Happens sometimes. It could be something wrong on either GitHub or Travis CI's side. Usually I just close and re-open the PR to retrigger the check.
cjerdonek commentedon May 15, 2020
I did try it twice, but I can keep trying.
vstinner commentedon May 16, 2020
I see that python/cpython#20105 is merged so it seems like the problem is gone :-)
I hope that the issue is now resolved.
vstinner commentedon May 16, 2020
If someone wants to investigate, https://travis-ci.org/python/cpython/builds gives the list of all Travis CI jobs of the CPython project.
cjerdonek commentedon May 16, 2020
Yes, I tried once more and it worked. Thanks for your help, @Mariatta and @vstinner.
brettcannon commentedon Jul 29, 2020
Both WIndows x64 and Travis are currently required, so closing.