You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Renaming issues/PRs incorrectly changes awaiting change review and awaiting merge to awaiting review #556
According to README, awaiting review has no incoming conditions:
flowchart TD
A([Published PR]):::creator
A_draft([New Draft PR]):::creator
A_draft -- publish draft by contributor --> A:::creator
A -- by contributor --> B[Awaiting review]:::anyone
A -- by core dev --> C[Awaiting core review]:::coredev
B & C -- new review by\nanother contributor --> C
C & B & E -- new core review\nrequests changes --> D[Awaiting changes]:::creator
D -- changes by contributor --> E[Awaiting change review]:::coredev
C & E & B -- new core review\napproves ---> F[Awaiting merge]:::coredev
G[When a review is dismissed\nthe highest remaining state is restored\nbased on the remaining reviews]
classDef creator stroke:#CC0;
classDef anyone stroke:#00C;
classDef coredev stroke:#0C0;
classDef triager stroke:#C0C;
linkStyle 0,1,7 stroke:#CC0,color:auto;
linkStyle 2,3 stroke:#00C,color:auto;
linkStyle 4,5,6,8,9,10 stroke:#0C0,color:auto;
Loading
I suspect the bug is here, in a handler of PR/issue modifications introduced in gh-555:
We need to check whether assignment of Blocker.core_review or Blocker.review is allowed before executing the else branch.
Ideally (for some distant future) we need to move tag management into a separate .py file that reads existing tags, checks if a new one is applicable, and removes the old ones. However, I have no free time to do it currently (because it requires massive modification of both reactors and their tests).
oops, you're right, this handler is doing way more than it was intended!
that handler should respond only to PR edits that change the PR from draft to published or from published to draft.
Activity
itamaro commentedon May 6, 2023
oops, you're right, this handler is doing way more than it was intended!
that handler should respond only to PR edits that change the PR from draft to published or from published to draft.
arhadthedev commentedon May 6, 2023
@itamaro Could you submit a PR, please?
pythongh-556: Fix over-reaching PR-edited event handler
itamaro commentedon May 6, 2023
of course
Add regression test for pythongh-556
gh-556: Fix over-reaching PR-edited event handler (#557)