Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local-part pattern accepts a final newline before the at-sign because
re.match()and$can leave that character unconsumed. For example,email("person\n@example.com")currently returnsTrue.Use
re.fullmatch()to require the local part to consume the entire value. The regression covers an ordinary name, a dotted name, an extended-Latin name, and a quoted name, with valid controls for each. All four newline cases fail on the unchanged source.On Python 3.12.2,
pytest . -qpasses with 1131 tests. Ruff lint and format checks, Pyright, Bandit, and wheel/sdist builds also pass.The open terminal-newline fix in #501 covers MAC and regional identifier validators; this change covers email local parts.