You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't understand. This is last extension build: https://readthedocs.org/builds/pillow/1903313/ (building 'PIL._imaging' extension)
Looks like extension are builded successfully, but still can't be imported. Also there is a warning about always_inline, but I think this can be a root of the problem.
@hugovk Thanks for pointing where logs can be found. Can you replace full logs with just a links? They are too long.
The thing that I don't understand is that it's importing Image from within the docs directory, so it should be looking at the installed version, not the version that's in the Pillow source directory.
I'm pretty sure that it's something with a sphinx (or a dependency) upgrade, since I was working on docs last week in this install, and the version on the site was similarly working at that point.
Ah, I just realized that the docs I was building last week were in a copy of my usual vm, which I still have hanging around. So I can probably track down the specific change, once I plug that drive in again.
Activity
hugovk commentedon Nov 29, 2014
The latest ReadTheDocs build passed but shows some import errors:
https://readthedocs.org/builds/pillow/1906522/
Last "good" build was 1 week, 2 days ago:
https://readthedocs.org/builds/pillow/1879312/
The following "bad" build was 1 day, 15 hours ago:
https://readthedocs.org/builds/pillow/1903282/
That last "bad" build was from this commit: 8a3302b
homm commentedon Nov 29, 2014
I don't understand. This is last extension build: https://readthedocs.org/builds/pillow/1903313/ (building 'PIL._imaging' extension)
Looks like extension are builded successfully, but still can't be imported. Also there is a warning about always_inline, but I think this can be a root of the problem.
@hugovk Thanks for pointing where logs can be found. Can you replace full logs with just a links? They are too long.
hugovk commentedon Nov 29, 2014
@homm I've replaced the long logs replaced with links. I didn't realise they're publicly viewable, good that they are.
I also don't see why it should be failing. @aclark4life @irskep Any ideas?
aclark4life commentedon Nov 29, 2014
Looks like 8a3302b broke
import _imaging.hugovk commentedon Nov 30, 2014
So, the last "good" build was commit b8d2a55:
https://readthedocs.org/builds/pillow/1879312/
b8d2a55 is a parent of 8a3302b, and 8a3302b was the first "bad" build:
https://readthedocs.org/builds/pillow/1903282/
I checked the "good" 8a3302b into a new branch in my repo and created an RTD project for my own repo.
Unsurprisingly the latest one failed:
https://readthedocs.org/builds/hugovk-pillow/1909066/
But the "good" b8d2a55 commit also failed:
https://readthedocs.org/builds/hugovk-pillow/1909067/
Perhaps an RTD environment change?
wiredfool commentedon Dec 1, 2014
Can we split the docs so that pillow.readthedocs.org goes to the latest released docs, for now 2.6.1?
hugovk commentedon Dec 2, 2014
We can build docs for any branch.
I just added 2.6.1, but not as pillow.readthedocs.org because it completely fails (unlike the other passes with ImportError):
https://readthedocs.org/builds/pillow/1913609/
wiredfool commentedon Dec 2, 2014
I just upgraded my sphinx (which downloaded some new dependencies as well) and broke it OMM. Reverting to the old sphinx I had (1.2.2) didn't help.
wiredfool commentedon Dec 2, 2014
So, make inplace && make docs works, but not make install && make docs.
aclark4life commentedon Dec 2, 2014
This sounds like an installation issue we worked on a while back.
wiredfool commentedon Dec 2, 2014
The thing that I don't understand is that it's importing Image from within the docs directory, so it should be looking at the installed version, not the version that's in the Pillow source directory.
I'm pretty sure that it's something with a sphinx (or a dependency) upgrade, since I was working on docs last week in this install, and the version on the site was similarly working at that point.
wiredfool commentedon Dec 2, 2014
Ah, I just realized that the docs I was building last week were in a copy of my usual vm, which I still have hanging around. So I can probably track down the specific change, once I plug that drive in again.
hugovk commentedon Dec 2, 2014
If you diff the "good" and "bad" builds above, you can see what's changed in Sphinx and dependencies' upgrades.
wiredfool commentedon Dec 2, 2014
FWIW, this is what I'm getting to the first error:
wiredfool commentedon Dec 2, 2014
The diff shows that the working one (https://readthedocs.org/builds/pillow/1879312/) already had
Jinja2>=2.7.1, and the non-working one (https://readthedocs.org/builds/pillow/1903282/) had to download and build the whole sphinx package, includingDownloading/unpacking Jinja2>=2.3 (from sphinx==1.2.2).