Repository navigation
ProtocolError on receive_data after connection is closed #1199
Description
Activity
Just want to chime in, we're seeing those errors some times too, we have a gRPC client with HTTP2 proxy, and the client throws this:
Traceback (most recent call last): File "/usr/lib/python3.5/asyncio/events.py", line 127, in _run self._callback(*self._args) File "/usr/lib/python3.5/asyncio/selector_events.py", line 730, in _read_ready self._protocol.data_received(data) File "/usr/local/lib/python3.5/dist-packages/aioh2/protocol.py", line 256, in data_received events_ = self._conn.receive_data(data) File "/usr/local/lib/python3.5/dist-packages/h2/connection.py", line 1463, in receive_data events.extend(self._receive_frame(frame)) File "/usr/local/lib/python3.5/dist-packages/h2/connection.py", line 1486, in _receive_frame frames, events = self._frame_dispatch_table[frame.__class__](frame) File "/usr/local/lib/python3.5/dist-packages/h2/connection.py", line 1725, in _receive_ping_frame ConnectionInputs.RECV_PING File "/usr/local/lib/python3.5/dist-packages/h2/connection.py", line 229, in process_input "Invalid input %s in state %s" % (input_, old_state) h2.exceptions.ProtocolError: Invalid input ConnectionInputs.RECV_PING in state ConnectionState.CLOSEDI'm guessing this is related to the connection being terminated but RECV_PING frames are still being sent?
I believe we are also seeing this in a relatively busy HTTP2 client in PrefectHQ/prefect#7442 — happy to investigate contributing a fix but I'm not sure how this should be handled.
Reacted by Jeff HaleReacted by Jeff HaleI believe this is related to #1181
H2 is closing the connection immeditietly after a GO_AWAY frame is received instead of waiting for a graceful termination after sending the connection terminated.
I am randomly getting this error on h2 3.1.1 (about once a week on a busy H2 client):
Unfortunately the code is somewhat complicated but I believe the connection closing logic to be correct. I never call close_connection and I quit receiving once ConnectionTerminated appears.
Possibly H2 is internally closing the connection due to ping timeout or other issue, and then throws me an error when the peer still sends something. Quite likely this actually happens when my laptop is in sleep, and H2 going ping-timeout meanwhile, with some data still in receive buffers. I would expect a ConnectionTerminated event in that case, after any remaining events are relayed, not an exception.