Pretty-print conformance TestResults in gtest failure output. - #30256
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_989404897
branch
4 times, most recently
from
October 3, 2026 00:06
b0f2307 to
f95f1e0
Compare
When a matcher on a TestResult fails, gtest prints the value it was given, which without a PrintTo() is an opaque byte dump. Print the test's priority and name (which spells out its input and output formats) and the response instead, truncating long payloads and decoding binary ones as the test's message type where possible, so that a failing conformance test can be read straight off the gtest output. The printer lives in the matcher library rather than with TestResult: matcher failures are the only place results get printed, and every test that checks a result includes matchers.h, which is all gtest needs to find PrintTo() through ADL. Its helpers (truncating a response, instantiating the test's message type, single-line printing) are file-local; the payload matchers that follow share them from the same file. PiperOrigin-RevId: 992625604
copybara-service
Bot
force-pushed
the
test_989404897
branch
from
October 3, 2026 00:30
f95f1e0 to
1c1899e
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty-print conformance TestResults in gtest failure output.
When a matcher on a TestResult fails, gtest prints the value it was given, which without a PrintTo() is an opaque byte dump. Print the test's priority and name (which spells out its input and output formats) and the response instead, truncating long payloads and decoding binary ones as the test's message type where possible, so that a failing conformance test can be read straight off the gtest output.
The printer lives in the matcher library rather than with TestResult: matcher failures are the only place results get printed, and every test that checks a result includes matchers.h, which is all gtest needs to find PrintTo() through ADL. Its helpers (truncating a response, instantiating the test's message type, single-line printing) are file-local; the payload matchers that follow share them from the same file.