Repository navigation
Adding some rounding and error messaging for subplots - #4153
Conversation
|
@AaronStiff - this is the PR to close #4124 - I mostly moved over your code here. I am seeing an NPM error in the CI/CD process though. Would you be available to review? |
|
@stephenpardy Great! I'm not really familiar with/involved in the build process though, but maybe @nicolaskruchten you could take a look? It would appear several other PRs are failing with the same issue. |
|
@alexcjohnson can you review this one plz? I'm not really available for the next few days |
|
@AaronStiff, @nicolaskruchten, or @alexcjohnson - just want to give this a gentle nudge to see if anyone is able to review and/or discuss the NPM build failure - I see that it is still around in some other PRs as well. Thank you. |
|
Thanks @stephenpardy - we did some other work in the last few days to fix build/CI issues so with any luck the tests will pass now that I updated the branch. Would you be able to add a test of the problem you're fixing, as well as an entry in the changelog? |
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Beautiful, thank you!
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
-->