镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Adding some rounding and error messaging for subplots - #4153

Merged
alexcjohnson merged 8 commits into
plotly:masterfrom
stephenpardy:handle_spacing_with_spec
May 5, 2023
Merged

alexcjohnson merged 8 commits into
plotly:masterfrom
stephenpardy:handle_spacing_with_spec

Conversation

@stephenpardy

@stephenpardy stephenpardy commented Apr 6, 2023 •

Copy link
Copy Markdown
Contributor

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

-->

@stephenpardy
stephenpardy marked this pull request as ready for review April 12, 2023 13:33
@stephenpardy

Copy link
Copy Markdown
Contributor Author

@AaronStiff - this is the PR to close #4124 - I mostly moved over your code here. I am seeing an NPM error in the CI/CD process though. Would you be available to review?

@AaronStiff

AaronStiff commented Apr 17, 2023 •

Copy link
Copy Markdown
Contributor

@stephenpardy Great! I'm not really familiar with/involved in the build process though, but maybe @nicolaskruchten you could take a look? It would appear several other PRs are failing with the same issue.

@nicolaskruchten

Copy link
Copy Markdown
Contributor

@alexcjohnson can you review this one plz? I'm not really available for the next few days

@stephenpardy

Copy link
Copy Markdown
Contributor Author

@AaronStiff, @nicolaskruchten, or @alexcjohnson - just want to give this a gentle nudge to see if anyone is able to review and/or discuss the NPM build failure - I see that it is still around in some other PRs as well. Thank you.

Comment thread packages/python/plotly/plotly/_subplots.py Outdated
@alexcjohnson

Copy link
Copy Markdown
Collaborator

Thanks @stephenpardy - we did some other work in the last few days to fix build/CI issues so with any luck the tests will pass now that I updated the branch. Would you be able to add a test of the problem you're fixing, as well as an entry in the changelog?

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Beautiful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants