镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(web): sidebar New thread skips the project dialog - #29973

Merged
maria-rcks merged 46 commits into
pingdotgg:maria/redesign/1-primitives-shellfrom
flamboh:t3/redesign-fix-sidebar-new-thread-direct
Nov 3, 2026
Merged

maria-rcks merged 46 commits into
pingdotgg:maria/redesign/1-primitives-shellfrom
flamboh:t3/redesign-fix-sidebar-new-thread-direct

Conversation

@flamboh

@flamboh flamboh commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Fix for the redesign stack, targets layer 1 (#28839).

Problem

With more than one project, the sidebar's New thread button and the New thread shortcut opened the command palette's project list first. After you picked one, you landed on the new-thread screen, which already has its own project picker (Recent, All projects…, No project, Add project…). That made you pick twice.

Fix

The button and the chat.new shortcut now open the new thread right away in the current project. That is the thread you are on, or else the first project in sidebar order. This is what Shift+click and single-project users already got. You change the project from the new thread's own Recent list. The palette only opens as a fallback when no project can be found, such as when every project is archived.

An existing empty draft for that project is reused, like the dialog path did. Shift+click now does the same as a plain click, so the tooltip drops the "Shift+click" hint. The per-project "New thread in " buttons and the palette's New thread in... list are unchanged.

Before / after

Captures pending.

Validation

  • vp run check:changed origin/maria/redesign/1-primitives-shell: all checks pass.
  • Local dev server with 4 projects, headless Chromium:
    • The sidebar button opens /draft/… with no dialog. Recent shows and the current project is selected.
    • Picking alpha from Recent moves the draft to alpha. Clicking the button again keeps that draft.
    • Ctrl+Shift+O from an existing thread opens the draft with no dialog.
    • At 600px wide, the sheet's button closes the sheet and opens the draft.

Made with Claude Opus 5.5 in Claude Code.

maria-rcks and others added 30 commits November 3, 2026 02:45
…turn absorbed its wake (pingdotgg#28010)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…ory scan ends (pingdotgg#29535)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tch (pingdotgg#29476)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…n starts (pingdotgg#28431)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ching origin (pingdotgg#27961)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…3804)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#23326)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Exotic209093 <134711311+Exotic209093@users.noreply.github.com>
Co-authored-by: Issue triage verification <triage@localhost>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#22661)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
… limit (pingdotgg#23192)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@maria-rcks
maria-rcks force-pushed the maria/redesign/1-primitives-shell branch from a9d9831 to 04f69aa Compare November 3, 2026 08:18
@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Nov 3, 2026
@maria-rcks
maria-rcks merged commit 3d9980b into pingdotgg:maria/redesign/1-primitives-shell Nov 3, 2026
17 checks passed
@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by claude-opus-5-5 on behalf of Maria

These are the captures this PR was missing. They were taken on the redesign stack (704e9d1bc6) before and after this change, with the same seeded data, 1280x720.

The change landed with one conflict resolution in chatRouteCommands.ts. The multi-project dialog branch was removed, and the stack's layout tab handling (layoutShowing() / openLayoutNewThreadTab()) was kept.

New thread from a focused thread

before: project dialog opens
after: draft opens in the focused thread's project

New thread from home

before: project dialog opens
after: draft opens in the first project in sidebar order

chat.new shortcut

before
after

Light

before
after

Switching project from the new-thread screen

before
after

Also checked:

  • Shift+click;
  • the per-project "New thread in" buttons;
  • the palette's "New thread in...";
  • single-project setups;
  • empty-draft reuse.

One known limit: an empty draft that is already open in a layout tab isn't reused, because layoutDraftIds excludes it.

EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 3, 2026
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Nov 3, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 3, 2026
maria-rcks pushed a commit to screen-gd/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 6, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 6, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 6, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 7, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 9, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 9, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 9, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 9, 2026
shivamhwp pushed a commit to shivamhwp/t3code that referenced this pull request Nov 11, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 11, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 11, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 11, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 11, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 12, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants