镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(web): chat tables and subagent rows line up #24835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3dotgg merged 3 commits into from
Oct 25, 2026
Merged

fix(web): chat tables and subagent rows line up #24835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2970482
fix(web): markdown table cells line up with surrounding text
t3dotgg Oct 25, 2026
d298ef7
fix(web): subagent row status and times line up
t3dotgg Oct 25, 2026
777d1bb
fix(web): table footer buttons stay inside the chat lane
t3dotgg Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/src/components/chat/MarkdownTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ export function MarkdownTable({ children, ...props }: ComponentProps<"table">) {
{children}
</table>
</ScrollArea>
<div className="mt-0.5 flex items-center justify-between select-none">
{/* Stays within the row's px-1: the chat lane clips sideways overflow. */}
<div className="mt-0.5 -mx-1 flex items-center justify-between select-none">
{hasClippedCells ? (
<Tooltip>
<TooltipTrigger
Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/components/chat/TimelineV2EventRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,12 @@ const V2SubagentGroup = memo(function V2SubagentGroup({
return (
<WorkLogBlock continues={row.continuesWorkLog}>
<Collapsible open={expanded} onOpenChange={toggleExpanded} data-subagent-group>
{/* pr-3.25 matches the panel border, padding, and row inset so the times line up. */}
<CollapsibleTrigger
aria-label={label}
aria-description={statusSummary}
className={cn(
"flex w-full min-w-0 items-center gap-3 py-2 text-left transition-opacity hover:opacity-100",
"flex w-full min-w-0 items-center gap-2.5 py-2 pr-3.25 text-left transition-opacity hover:opacity-100",
expanded || summary.active
? "text-foreground opacity-100"
: "text-muted-foreground opacity-55",
Expand Down
23 changes: 8 additions & 15 deletions apps/web/src/components/chat/V2LifecycleRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,21 +439,7 @@ function SubagentTimelineLink(props: {
status={status ?? undefined}
/>
<span className="min-w-0 flex-1">
<span className="flex items-baseline gap-2">
<span className="min-w-0 truncate text-xs font-medium text-foreground">
{props.title}
</span>
{detail !== null && (props.event !== undefined || status !== "completed") ? (
<span
className={cn(
"shrink-0 text-3xs",
failed ? "text-destructive" : "text-muted-foreground",
)}
>
{statusLabel}
</span>
) : null}
</span>
<span className="block truncate text-xs font-medium text-foreground">{props.title}</span>
<span
className={cn(
"block text-2xs leading-relaxed",
Expand All @@ -469,6 +455,13 @@ function SubagentTimelineLink(props: {
)}
</span>
</span>
{detail !== null && (props.event !== undefined || status !== "completed") ? (
<span
className={cn("shrink-0 text-xs", failed ? "text-destructive" : "text-muted-foreground")}
>
{statusLabel}
</span>
) : null}
<span className="shrink-0 text-xs text-muted-foreground tabular-nums">
{props.event ? props.event.timestamp : <SubagentElapsed agent={timing} />}
</span>
Expand Down
11 changes: 11 additions & 0 deletions apps/web/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,10 +2135,21 @@ code {
font-size: 0.75rem;
}

/* Top-aligned so wrapped rows share a first line, and the outer columns sit
flush with the surrounding prose. */
.chat-markdown th,
.chat-markdown td {
padding: 0.45rem 0.75rem;
text-align: start;
vertical-align: top;
}

.chat-markdown :is(th, td):first-child {
padding-inline-start: 0;
}

.chat-markdown :is(th, td):last-child {
padding-inline-end: 0;
}

.chat-markdown thead th {
Expand Down
Loading