Repository navigation
fix(web): expanded tool output stays above the composer - #24436
Draft
juliusmarminge wants to merge 5 commits into
Draft
juliusmarminge wants to merge 5 commits into
juliusmarminge wants to merge 5 commits into
Conversation
When the timeline is not pinned to the end, expanding a work group, reasoning, command output, or subagent group now scrolls just enough for the revealed content to clear the composer, never moving the clicked header off screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fetched tool details, syntax highlighting, and row measurement can grow the expanded content after the two settle frames. The reveal now keeps following size changes for up to 3s, capped by the header, and stops on wheel, touch, pointer, or key input, on the next toggle, and on unmount or navigation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… over Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Composer PageUp/PageDown, find, and citations move the timeline from outside its viewport, so a late resize could undo that navigation. Takeover now listens on the document; trigger recording stays on the viewport. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Generated by claude-opus-5-5 This can be closed: #21967 is already fixed on The attached script runs #21968's five To reproduce, run
Result |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Expanding a tool call or reasoning row near the composer while the timeline is above its end leaves the expanded content hidden behind the composer. The row header stays fixed even when later detail fetching makes its body taller.
Change
Reveal expanded content above the composer, capped so the activated header remains visible. Follow late content layout until the user interacts again, collapses the disclosure, or leaves the thread. Preserve existing collapse and pinned-to-end behavior.
Scope and approval
Fixes #21967
Triaged bug via the automated issue flow.
GitCafe: #21967
Verification
vp run check:changedpassed after integrating main: format, lint, both knip checks, scoped typecheck, and 96 tests in three files.Evidence
Before d53873b6a4; after a92c50fef3. Real dev-server app, Chrome 154/Linux, DPR 2, 16px root font, frozen clock. CSS viewports 1440×900 and 390×844, both themes.
Full timestamped evidence index includes eight recordings, 56 stills, 28 before/after pairs with zero-threshold amplified and threshold-8 diffs, and the complete visible-difference list. Reproduction seed; complete artifact archive.
What else changed visibly: surrounding timeline text and headers move with the intended reveal; the scroll-to-end overlay moves relative to content. One desktop-light pre-toggle pair differs in timestamp/copy hover controls. Recordings contain pointer/click indicators and profile setup transitions.
Proof audit pass 2: core evidence credible, full matrix INSUFFICIENT. The auditor independently rebuilt command-open with zero changed pixels, recomputed all 28 diff counts exactly, and inspected all stills and recording keyframes. Delayed growth and takeover cancellation remain unverified; no implementation defect was established by the proof audit.
Remaining verification
This PR remains draft: six of eight matrix families have partial evidence; none has complete matrix coverage. Delayed detail/media arrival, live transitions, the full tool gallery, attempt folds, tall-content bounds, thread-switch cleanup, and conclusive takeover cancellation remain unverified. Actual Electron and remote smoke are also unverified. The final document-wide takeover correction has scoped checks but no fresh independent review after the three review rounds.
Capture export limits: desktop PNGs were downsampled to 1280×800 despite the measured 1440×900 CSS viewport; narrow PNGs are 780×1688. Recording resize changes produce letterboxing. Narrow collapsed-composer measurements do not establish exact inset arithmetic. These captures demonstrate the core command/reasoning improvement, not a complete proof pass. CI and bot review remain pending; no bugfix gate label is applied.
Models: Claude Opus 5.5 implementation; GPT-6.1-Sol and Claude Opus 5.5 review; Codex and Claude Agent harnesses in T3 Code.