镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

758: improve performance - #762

Merged
asgrim merged 5 commits into
php:1.6.xfrom
asgrim:758-improve-performance
Oct 7, 2026
Merged

asgrim merged 5 commits into
php:1.6.xfrom
asgrim:758-improve-performance

Conversation

@asgrim

@asgrim asgrim commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #758

supersedes #759 ; although that PR solved the immediate issue, the root cause was really careless management of the repository; there were multiple instantiations of the platform repo, which cascaded into so many PhpBinaryPath calls. Some calls have been eliminated, or run with -n to speed up slightly; but primarily we've removed the need to call those so many times anyway.

On OSX I was originally seeing:

Processes started: 925 in 18.52s
  php: 114 in 14.57s (127.8ms avg)
  pkg-config: 810 in 3.94s (4.9ms avg)
  php-config: 1 in 0.01s (7.2ms avg)

Now after this change, seeing:

Processes started: 22 in 1.30s
  php: 15 in 1.24s (82.6ms avg)
  pkg-config: 6 in 0.06s (9.6ms avg)
  php-config: 1 in 0.01s (6.6ms avg)

(this was tested with command

time PIE_DEBUG_PROCESS_COUNT=1 CPATH=/opt/homebrew/include bin/pie install mongodb/mongodb-extension apcu/apcu pecl/pcov phpredis/phpredis noisebynorthwest/php-spx xdebug/xdebug bsn4/grpc  --with-zlib-dir=/opt/homebrew/opt/zlib -v

This should serve as a good improvement to performance on OSX platforms, where this performance issue seemed to be most prevalent. It's improved Linux performance too, but it will be less noticeable anyway as it was already fast.

PR submitter checklist

@asgrim asgrim added this to the 1.6.0 milestone Oct 6, 2026
@asgrim asgrim self-assigned this Oct 6, 2026
@asgrim asgrim added the enhancement New feature or request label Oct 6, 2026
@asgrim asgrim mentioned this pull request Oct 6, 2026
3 of 4 tasks
@asgrim
asgrim merged commit a3436c0 into php:1.6.x Oct 7, 2026
71 of 72 checks passed
@asgrim
asgrim deleted the 758-improve-performance branch October 7, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slow no-op installs on macOS: repeated PHP and pkg-config subprocesses

1 participant