Repository navigation
fix: return 404 when the script can't be opened - #2791
Merged
Merged
Conversation
Like php-fpm and php-cgi, FrankenPHP now opens the primary script before running it and answers 404 "No input file specified." (403 "Access denied." when it isn't readable) instead of compiling a missing file, which answered 200 with a PHP error. php_server relied on Caddy's first_exist_fallback never falling back to a missing index.php. Caddy fixed that policy in caddyserver/caddy@4ec5a5c, so without this change, php_server sites without an index.php answer unknown paths with a 200.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like php-fpm and php-cgi, FrankenPHP now opens the primary script before running it. When that fails, it answers 404
No input file specified.(403Access denied.when the file isn't readable) instead of compiling a missing file, which answered 200 with a "Failed opening required" fatal error.This is needed for the next Caddy release: Caddy fixed
first_exist_fallback(caddyserver/caddy@4ec5a5c), which now really falls back to a missingindex.php. Without this change,php_serversites without anindex.phpwould answer unknown paths with a 200 instead of a 404.A worker whose script disappears still exits with status 255, so it keeps counting as a failure.