Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile has five "cereal/*.capnp.go" rules that are the same rule with a different file name. This replaces them with one "%.capnp.go: %.capnp" pattern rule. "capnp compile -ogo" writes the ".go" file next to the schema, so "$<" gives the same command each rule had. The "capnp" target still lists the five files, so a new schema only needs adding there.
Audit report
Testing
In "golang:1.26.2-bookworm" with Debian's "capnp":
Difference
If a schema is deleted but its ".capnp.go" is left behind, main stops with "No rule to make target", while the pattern rule says "Nothing to be done" and keeps the old file.