Repository navigation
fix(core): preserve context tiers in peak rates (carries #165) - #193
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Memory benchmarkCompared base
Interpretation: Differences larger than their measured MAD: Stable RSS +0.4 MiB ± 0.3 MiB, Physical footprint +0.2 MiB ± 0.1 MiB, Physical peak +1.1 MiB ± 0.4 MiB. Extension overhead above pi baseline
Values are medians of 6 alternating, paired runs. The value after Environment: pi
|
Follow up the #165 peak-tier carry in #193: copy readonly catalog costs into independent mutable tables at the native host boundary. Preserve generic cost selection and generate arithmetic. Add a typed assignment and frozen-catalog mutation regression test. No claim of exhaustive index typecheck coverage.
pierreraby
force-pushed
the
carry/pr165-peak-tiers
branch
from
November 4, 2026 13:28
3e5964c to
d6fc3a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries #165's peak-tier fix (
188a344) by @patlux / Patrick Wozniak, credited as co-author. The first carry commit preserves the original source/test change. A separately reviewed integration adaptation now converts readonly catalog costs into independent mutable native-host tables (including a new array and tier objects), and index uses that adapter. The generic selector and generate arithmetic retain their existing contracts.Keep context tiers and double their rates alongside the base table in peak windows. This guards a synthetic combination: no currently time-priced model has context tiers, so no current model's billed/display rate is asserted to change.
Integration adaptation
An expanded type probe found a new readonly-tier incompatibility with Pi's native
Model['cost']contract. A minimal probe passes against main's original selector and fails with the unadapted generic carry return. The native adapter resolves that specific incompatibility without casts or mutation of the readonly catalog. Its mutable return shape is checked by the normal project typecheck and frozen-catalog mutation tests; index itself remains outside the project tsconfig.Fresh read-only review of the functional adaptation by an independent DeepSeek V4.1 Flash session: OK with notes, no blocking finding. A later comment/changelog clarification only qualifies coverage; helper and test code are unchanged from the reviewed delta. This is not a claim of exhaustive host typechecking: the 17 inherited index diagnostics remain a separate follow-up.
Validation
npm teston the rebased PR head: PASS, including project typecheck and required real Pi/OMP integrations against mocks.No live login or billed API tests, no dependency installation, no release/tag/publication. Original #165 remains open; this PR does not close it automatically.