镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(core): reset transport on explicit refresh (carries #165) - #192

Merged
pierreraby merged 1 commit into
mainfrom
carry/pr165-refresh-transport
Nov 4, 2026
Merged

pierreraby merged 1 commit into
mainfrom
carry/pr165-refresh-transport

Conversation

@pierreraby

Copy link
Copy Markdown
Collaborator

Summary

Carries #165's refresh/reset wiring (0025369) by @patlux / Patrick Wozniak, credited as co-author. Independent main-based PR.

  • Connect /commandcode-refresh to the existing router reset so upgraded Go accounts re-probe with the same key.
  • Address the original review's race: generation-guard probe assignments so pre-reset requests cannot restore stale generate/provider state after the same key is reused.
  • Exercise actual index.ts wiring through real Pi RPC: Go fallback → sticky generate after simulated upgrade → refresh clears probe → next request reaches Provider API.

Validation

  • Original runtime reset regression fails on main.
  • Same-key race regression fails without the new generation guard.
  • Real Pi wiring regression fails when only resetTransport: transport.reset is removed (status remains generate instead of unknown).
  • Final full npm test: PASS, including runtime 13/13, transport/normalizer 20/20, typecheck, real Pi RPC and OMP mock integration.
  • Format and diff checks: PASS.
  • Active all-server LSP: zero diagnostics, 4 clean / 2 inconclusive. Existing project tsconfig excludes index; the real-host test explicitly guards this one-line wiring change. Separate inferred-project baseline errors on unchanged index copies in other carry worktrees are not claimed fixed here.

No real credentials, billed requests, fresh independent review, merge or release. #165 remains open. Happy to close if @patlux prefers landing directly.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Memory benchmark

Compared base c417083 with PR head c51dbef on the same GitHub-hosted darwin runner. Lower values are better.

Metric Base PR PR − Base Change
Stable RSS 107.1 MiB ± 1.0 MiB 108.0 MiB ± 0.1 MiB +0.6 MiB ± 0.8 MiB +0.6%
Physical footprint 61.0 MiB ± 0.6 MiB 61.8 MiB ± 0.8 MiB +0.7 MiB ± 0.7 MiB +1.1%
Physical peak 73.2 MiB ± 1.3 MiB 73.9 MiB ± 0.5 MiB +1.0 MiB ± 0.6 MiB +1.3%

Interpretation: Differences larger than their measured MAD: Physical peak +1.0 MiB ± 0.6 MiB.

Extension overhead above pi baseline

Metric Base overhead PR overhead Difference
Stable RSS +5.0 MiB ± 0.5 MiB +5.3 MiB ± 0.8 MiB +0.6 MiB ± 0.8 MiB
Physical footprint +2.6 MiB ± 0.4 MiB +3.4 MiB ± 1.5 MiB +0.7 MiB ± 0.7 MiB
Physical peak +3.3 MiB ± 1.3 MiB +4.5 MiB ± 1.6 MiB +1.0 MiB ± 0.6 MiB

Values are medians of 6 alternating, paired runs. The value after ± is the median absolute deviation (MAD). Each process was sampled 12 times after a 2500 ms warm-up.

Environment: pi 0.84.4, Bun 1.4.4, darwin arm64. RSS comes from ps; physical footprint and peak come from macOS footprint.

This is a comparative signal, not a pass/fail threshold. GitHub-hosted runner noise can affect absolute values.

Carries #165 by patlux. Add a probe generation guard against pre-reset same-key races and verify the index wiring through real Pi RPC.

Co-authored-by: Patrick Wozniak <email@patwoz.de>
@pierreraby
pierreraby force-pushed the carry/pr165-refresh-transport branch from 7d4840e to c51dbef Compare November 4, 2026 13:21
@pierreraby
pierreraby merged commit b09283a into main Nov 4, 2026
15 checks passed
@pierreraby
pierreraby deleted the carry/pr165-refresh-transport branch November 4, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant