Repository navigation
AO3-7610 Fix Tag Wranglers page title and header - #6044
theresenvirata wants to merge 4 commits into
Conversation
marcus8448
left a comment
There was a problem hiding this comment.
Thanks for working on this!
It looks like there are some tests (in tag_wrangling.feature and tag_wrangling_more.feature) that need updating since the text changed. Since the new text (Wranglers) is in the navigation sidebar it would be good to update the tests to check for text that is more unique to the page (maybe Assign Wranglers to Fandoms?)
|
Whoops sorry I didn't mean to click for review request. I'll work on the change now. |
marcus8448
left a comment
There was a problem hiding this comment.
One last thing - could you please revert the formatting/rubocop changes in the last two commits? While we do want new and updated code to pass the linter, we generally want to avoid making formatting changes on unrelated lines. This keeps the diff small and prevents potential headaches when merging. Everything else looks good!
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7610
Purpose
Changes the Tag Wrangling browser page from "Tag Wranglers | Archive of Our Own" to "Wranglers | Archive of Our Own." Also changes the Tag Wrangling page h2 heading from "Tag Wrangling Assignments" to "Wranglers", matching the sidebar link.
Testing Instructions
Login with an account that has Tag Wrangling permissions. Head to the Tag Wrangling page and click on the Wranglers link in the sidebar.
Credit
Therese Virata (she/her)