镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

AO3-7610 Fix Tag Wranglers page title and header - #6044

Open
theresenvirata wants to merge 4 commits into
otwcode:masterfrom
theresenvirata:AO3-7610
Open

theresenvirata wants to merge 4 commits into
otwcode:masterfrom
theresenvirata:AO3-7610

Conversation

@theresenvirata

Copy link
Copy Markdown

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7610

Purpose

Changes the Tag Wrangling browser page from "Tag Wranglers | Archive of Our Own" to "Wranglers | Archive of Our Own." Also changes the Tag Wrangling page h2 heading from "Tag Wrangling Assignments" to "Wranglers", matching the sidebar link.

Testing Instructions

Login with an account that has Tag Wrangling permissions. Head to the Tag Wrangling page and click on the Wranglers link in the sidebar.

Credit

Therese Virata (she/her)

@theresenvirata theresenvirata changed the title fix Tag Wranglers page title and header AO3-7610: fix Tag Wranglers page title and header Sep 26, 2026
@theresenvirata theresenvirata changed the title AO3-7610: fix Tag Wranglers page title and header AO3-7610 Fix Tag Wranglers page title and header Sep 26, 2026

@marcus8448 marcus8448 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

It looks like there are some tests (in tag_wrangling.feature and tag_wrangling_more.feature) that need updating since the text changed. Since the new text (Wranglers) is in the navigation sidebar it would be good to update the tests to check for text that is more unique to the page (maybe Assign Wranglers to Fandoms?)

Comment thread app/controllers/tag_wranglers_controller.rb Outdated
Comment thread app/views/tag_wranglers/index.html.erb Outdated
Comment thread app/controllers/tag_wranglers_controller.rb Outdated
@theresenvirata

theresenvirata commented Sep 29, 2026 •

Copy link
Copy Markdown
Author

Whoops sorry I didn't mean to click for review request. I'll work on the change now.

@marcus8448 marcus8448 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing - could you please revert the formatting/rubocop changes in the last two commits? While we do want new and updated code to pass the linter, we generally want to avoid making formatting changes on unrelated lines. This keeps the diff small and prevents potential headaches when merging. Everything else looks good!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants