镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

AO3-7612 Update browser page title on the Unassigned Fandoms page - #6039

Open
yujeanshin wants to merge 5 commits into
otwcode:masterfrom
yujeanshin:AO3-7612
Open

yujeanshin wants to merge 5 commits into
otwcode:masterfrom
yujeanshin:AO3-7612

Conversation

@yujeanshin

@yujeanshin yujeanshin commented Sep 24, 2026 •

Copy link
Copy Markdown

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7612

Purpose

This changes the browser page title on the Unassigned Fandoms page from "Unassigned Fandom | Archive of Our Own" to "Unassigned Fandoms | Archive of Our Own". The page heading is left as-is.

Credit

yshin, she/her

@sarken

sarken commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Hi, yshin!

Thank you so much for this pull request. Someone will be along to review it soon.

For now, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

Comment thread config/locales/views/en.yml Outdated
Comment on lines +1161 to +1162
unassigned:
page_title: Unassigned Fandoms

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Could you move this locale string to locales/controllers/en.yml instead? Since we set the locale in the controller we want to define it in the controller related locale file

@Bilka2

Bilka2 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Additionally, could you add a test for this?

@Bilka2 Bilka2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants