Repository navigation
Inline-block may cause Chrome's built-in search to fail to match the corresponding content #101
Description
react-diff-view/src/styles/index.css
Line 77 in 72868c2
Assuming that the rendered code is like this
<td class="diff-code diff-code-insert" style="user-select: auto;">
<span class="diff-code-edit">
<span class="token function">onU</span>
</span>
<span class="token function">pdat</span>
<span class="diff-code-edit">
<span class="token function">e</span>
</span>
</td>When I use ctrl+f to search for "onUpdate" on the webpage, I cannot find the above one because the display of .diff-code-edit is inline-block.
I think display: inline-block should be changed to display: inline.
Activity
otakustay commentedon Jul 28, 2020
Aware of this issue, but currently I can't find an appropriate solution,
inline-flexalso breaks searchotakustay commentedon Jul 28, 2020
But why we are using
inline-block, just can't remember, any idea @dancerphil ?otakustay commentedon Jul 28, 2020
https://bugs.chromium.org/p/chromium/issues/detail?id=1094588&q=search%20inline-block&can=2
stale commentedon Aug 11, 2020
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
ensorrow commentedon Jun 30, 2023
already fixed in #200