[xueqzhan]

Bump ScalingReplicaSet event threshold since all oidc proxy tests could be in the same shard.

Summary by CodeRabbit

• Tests
  • Authentication component-proxy event matching now supports up to 90 repeated events, increased from 55. The existing namespace, deployment, and event-reason criteria remain unchanged. This expands the range of event sequences recognized by the tests; no user-facing behavior changes are included in this update.

[openshift-merge-bot]

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

[openshift-ci-robot]

@xueqzhan: This pull request references Jira Issue OCPBUGS-130592, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump ScalingReplicaSet event threshold since all oidc proxy tests could be in the same shard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xueqzhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 082c3d35-a503-4da0-864c-007e5725289c

📥 Commits

Reviewing files that changed from the base of the PR and between f5c8eab and 718a0f4.

📒 Files selected for processing: 1

• pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The AuthenticationComponentProxyScalingReplicaSet matcher now permits up to 90 repeats instead of 55. Its namespace, deployment, and event-reason matching conditions remain unchanged.

Changes

Authentication event matching

Layer / File(s)	Summary
Increase repeat threshold pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go	The matcher’s repeat threshold increases from 55 to 90. Its other matching conditions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: gangwgr

Merge Risk: ⚪ Minimal · up to 718a0

The repeat limit increases from 55 to 90 for the stated OIDC test-sharding scenario. No concrete user-facing or operational regression is established in the available evidence, so no actionable merge blocker remains.

Pre-merge checks: 15

Passed checks: 15 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the main change: increasing the ScalingReplicaSet event threshold. It matches the code change and PR objective.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names		PASS. The pull request changes only the repeatThresholdOverride value from 55 to 90 in a pathological-event matcher. It does not add or modify any Ginkgo test title, so it introduces no unstable or …
Test Structure And Quality		PASS: The pull request changes one repeatThresholdOverride value from 55 to 90 in duplicated_event_patterns.go. It does not add or modify a Ginkgo It block, setup/cleanup, cluster wait, or asser…
Microshift Test Compatibility		The pull request changes only the ScalingReplicaSet repeat threshold from 55 to 90 in an existing pathological-event matcher. It adds no Ginkgo tests and introduces no MicroShift API or feature usag…
Single Node Openshift (Sno) Test Compatibility		PASS: The pull request changes only the repeatThresholdOverride from 55 to 90 for an existing pathological-event matcher. It adds no Ginkgo tests and introduces no multi-node or HA assumption.
Topology-Aware Scheduling Compatibility		The pull request changes only a Go test-event matcher threshold in pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go. It does not add or modify deployment manifests, opera…
Ote Binary Stdout Contract		PASS. The pull request changes only repeatThresholdOverride from 55 to 90 in AuthenticationComponentProxyScalingReplicaSet. The diff adds no stdout write and does not modify main, suite setup, l…
Ipv6 And Disconnected Network Test Compatibility		The pull request changes only repeatThresholdOverride from 55 to 90 in an existing pathological event matcher. It adds no Ginkgo tests and introduces no IPv4 assumptions or external connectivity req…
No-Weak-Crypto		The pull request changes only repeatThresholdOverride from 55 to 90 in a pathological-event matcher. It adds no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret-comparison lo…
Container-Privileges		The pull request changes only one Go matcher threshold, from 55 to 90, in duplicated_event_patterns.go. It does not add or modify a container or Kubernetes manifest, and it introduces none of the li…
No-Sensitive-Data-In-Logs		PASS. The pull request changes only repeatThresholdOverride from 55 to 90. It adds no logging and does not change logged fields, messages, or event matching. The matcher remains limited to the `Scal…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

[redhat-chai-bot]

Chai test selection for 718a0f4d70f48f2ef35ff9c88a3245c7184effaf → main

• pull-ci-openshift-origin-main-e2e-gcp-ovn

Reason: Single-line threshold bump (55→90) in the pathological event monitor for oauth-openshift ScalingReplicaSet events. Functional change to the openshift-tests binary's event evaluation logic. One general parallel e2e test (e2e-gcp-ovn) verifies the monitoring framework operates correctly with the new threshold on a standard OCP cluster where oauth-openshift is present. Other candidates excluded: CSI/storage/build/image-registry/kubevirt/jenkins tests don't exercise this event matcher; MicroShift lacks the oauth-openshift deployment; additional platforms add no coverage for a numeric constant change; serial tests don't match the parallel-shard co-location scenario the PR addresses.

/test e2e-gcp-ovn

[redhat-chai-bot]

/pipeline mark-pipeline-gate 718a0f4

[openshift-ci]

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.