Repository navigation
fix: preserve empty structured shell results - #5423
Merged
Merged
Conversation
jbeckwith-oai
requested review from
a team,
rm-openai and
seratch
as code owners
October 26, 2026 21:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
dpiet-oai
approved these changes
Oct 26, 2026
marcuswood-oai
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve
ShellResult(output=[])as an empty structured result instead of wrapping the display placeholder(no output)as stdout and inventing exit code zero. Display rendering and string-returning executors keep their existing behavior.Add Runner-level regression coverage for ordinary and streamed runs, checking the next model request, retained raw output, metadata, and output limits.
Test plan
XDG_STATE_HOMEand a path withoutuser, avoiding unrelated environment-sensitive assertions.Issue number
Closes #5348
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR