镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(auth): document SSH login fallback - #1294

Merged
mldangelo-oai merged 3 commits into
mainfrom
mdangelo/codex/auth-ssh-forwarding
Oct 5, 2026
Merged

mldangelo-oai merged 3 commits into
mainfrom
mdangelo/codex/auth-ssh-forwarding

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

When device auth is disabled, the missing-credentials message points users to login help for browser login over SSH. Help and docs show the local SSH command and the remote login command.

Changes

  • Explain that device auth needs workspace permission, including in container examples.
  • Show where to run the SSH and login commands, then open the sign-in URL in a local browser.
  • Check that help keeps SSH and login commands intact on narrow terminals.

Testing

  • Focused auth/help tests: 202 passed, 0 failed (seed 1168579403). SDK types, format, and build:ci passed.
  • Earlier full SDK runs (seeds 12345 and 2698542794): each had 3,544 passed, 53 skipped, and 26 failed. All 26 passed targeted reruns: 25 with umask 022, one from the package directory. Representative failures also reproduced on an unmodified baseline. The full suite has not been rerun for the final copy cleanup.

Risk and rollout

This updates guidance for Codex's existing browser login. You need a local browser and SSH access to the remote machine.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 5, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T16:44:43.749484Z d007953 New commits
🔒 Security Review ✅ Completed 2026-10-05T16:45:40.267423Z d007953 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete actual PR contribution and changed tests with three independent passes, followed by targeted synthesis. Static review only; product tests were not executed.

No supported introduced correctness or security finding remained in this contribution. Source approval does not establish CI, merge readiness, integration or deployment.

@mldangelo-oai
mldangelo-oai merged commit 7beb1ac into main Oct 5, 2026
60 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/auth-ssh-forwarding branch October 5, 2026 18:19
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants