Repository navigation
refactor(tests): simplify fixtures and eval tooling - #1292
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete actual PR contribution and changed tests with three independent passes, followed by targeted synthesis. Static review only; product tests were not executed.
No supported introduced correctness or security finding remained in this contribution. Source approval does not establish CI, merge readiness, integration or deployment.
Summary
SDK tests and SastBench tooling repeat fixture bookkeeping, copier callbacks and private compatibility checks. Reuse existing helpers and remove the unused paths while preserving supported behavior. The complete formatted patch removes 54 maintained lines across 21 files: 45 test lines and 9 tooling lines, with production code unchanged.
Changes
Testing
Risk and rollout
No public CLI, SDK API, production implementation or dependency changes. Public validation, case-ID formatting, fixture permissions and failure ordering remain intact. This is local macOS qualification; native Windows execution and a live Promptfoo CLI evaluation were not rerun. No rollout or migration is required.
Public disclosure review