镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(plugin): resolve parents of new artifact storage roots - #1241

Merged
mldangelo-oai merged 2 commits into
mainfrom
mdangelo/codex/scan-storage-containment
Oct 5, 2026
Merged

mldangelo-oai merged 2 commits into
mainfrom
mdangelo/codex/scan-storage-containment

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Resolve existing parent directories before checking a new standalone artifact location, so relocated storage follows the existing outside-target rule.

Changes

  • Reuse the existing path-resolution helper for persistent standalone storage.
  • Cover missing external storage, configured directory aliases, and the default state-directory fallback through the real MCP save operation.

Testing

  • Migrated artifact-storage integration and regression suites: 24 passed on Linux, including the fallback regression and configured directory aliases.
  • SDK and MCP type checks, SDK and plugin formatting, Ruff checks/format, SDK CI compilation, source compatibility, and all 9 compatibility tests passed.
  • git diff --check passed.

Risk and rollout

One production-line change; existing storage rules and error text are preserved. The permission-based fallback regression runs on POSIX as a non-root user; directory-alias controls also cover Windows junctions. No commands, flags, environment variables, or defaults change.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 5, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T14:57:00.419948Z b422445 New commits
🔒 Security Review ✅ Completed 2026-10-05T14:57:43.683099Z b422445 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full contribution at b4224458f7f3b37751e35159a722bac067a74fa2 with selected base 2d8053142e00c03cfb473b3b6be5cf03669ae494, including changed tests and touched context, using three independent reviews followed by root synthesis.

No supported introduced finding.

Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.

@mldangelo-oai
mldangelo-oai merged commit c2567c2 into main Oct 5, 2026
76 of 95 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/scan-storage-containment branch October 5, 2026 19:31
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants