Repository navigation
fix(plugin): resolve parents of new artifact storage roots - #1241
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
approved these changes
Oct 5, 2026
alandelong-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full contribution at b4224458f7f3b37751e35159a722bac067a74fa2 with selected base 2d8053142e00c03cfb473b3b6be5cf03669ae494, including changed tests and touched context, using three independent reviews followed by root synthesis.
No supported introduced finding.
Static source review; tests were inspected but not executed. CI, mergeability and integration are separate.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve existing parent directories before checking a new standalone artifact location, so relocated storage follows the existing outside-target rule.
Changes
Testing
git diff --checkpassed.Risk and rollout
One production-line change; existing storage rules and error text are preserved. The permission-based fallback regression runs on POSIX as a non-root user; directory-alias controls also cover Windows junctions. No commands, flags, environment variables, or defaults change.
Public disclosure review