Repository navigation
fix(cli): preserve custom provider authentication in skill commands - #1187
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42362911a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kmbroai
left a comment
There was a problem hiding this comment.
Reviewed provider configuration merging and authentication selection. All 40 added provider-authentication cases pass locally; the broader authentication suite's failures reproduce unchanged on the base. Full hosted CI passed on this head. No new blocking findings.
soyeon-oai
left a comment
There was a problem hiding this comment.
Source review focused on simplification; no tests were run.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9c6c0779a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Make standalone validation, patch, and fix-verification commands honor custom provider authentication and explicit ChatGPT selection.
Changes
env_keyprecedence underautoandapi-key, including providers that also support OpenAI account authentication.--auth chatgptwith a customenv_keyorexperimental_bearer_token, select stored account authentication in the child environment and native runtime configuration, including whenrequires_openai_authis false or omitted. Preserve the original environment, configuration objects, and ambient config file.Testing
build:ci, plugin source compatibility, and its 9 regression tests.git diff --checkpassed.c9c6c07, seed 12345 (120s test timeout): 3,512 passed, 53 skipped, 0 failed. The final bearer-only fix has the 275 focused passing checks above.Risk and rollout
Changes affect skill-command provider authentication. Explicit ChatGPT selection uses stored account credentials for custom API-key providers. Credential storage and path protections remain enforced; per-command settings do not mutate shared environment or ambient configuration. A CLI release is needed for users to receive the fix.
Public disclosure review