Repository navigation
docs: prohibit reintroducing CLI secret and log redaction - #1178
Merged
Merged
Conversation
kmbroai
marked this pull request as ready for review
October 1, 2026 19:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
soyeon-oai
approved these changes
Oct 1, 2026
soyeon-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed against base 4096958. No blocking findings. The change is limited to 11 added lines in AGENTS.md, keeps all pre-existing guidance unchanged, and explicitly retains upstream protections and artifact/publication safeguards. Documentation-only review; no local runtime tests run. GitHub node-ci and title validation both passed.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the CLI implementation policy against adding or reintroducing secret and log redaction so future changes preserve diagnostic context for local troubleshooting.
Changes
AGENTS.mdprohibiting CLI-layer secret and log redaction.Testing
git diff HEAD^ HEAD --checkpassed.AGENTS.mdis the only changed file.Risk and rollout
Documentation only; this change does not alter runtime redaction, environment variables, SDK behavior, or native protections. It establishes guidance for future CLI implementation work. No release or rollout is required.
Public disclosure review