Repository navigation
feat(dedupe): attribute records reviews to participating observations - #1145
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1403d91a3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
soyeon-oai
left a comment
There was a problem hiding this comment.
LGTM at 1403d91. I traced participant IDs through screening and pair scheduling, host-ID mapping, and JSON-RPC serialization. The beneficiary/context split matches invocation anchor membership, invalid attribution fails before host execution, and saved-scan checkpoint behavior remains unchanged.
I verified the successful hosted CI run, including the records attribution, retry, compatibility, and real CLI pipe tests. The existing documentation formatting nit is nonblocking. This was source and hosted-CI review; I did not independently run tests or validate live host/backend integration.
Summary
Records-mode review requests now identify the exact participating host observations, separating incoming beneficiaries from comparison-only context. Hosts can consume these identities without parsing prompts or inferring membership from final groups.
Changes
attributionmetadata with version 1 and sorted, distinct beneficiary/context arrays. Every records-mode request supplies it; missing or unknown participants fail before host execution.Testing
Risk and rollout
The metadata is additive and older hosts can ignore it. Hosts requiring attribution should validate and persist it with the request UUID before provisioning execution. This change adds no accounting logic, command, model producer, checkpoint behavior, release, or deployment. Synthetic protocol tests do not establish live host/backend integration.
Public disclosure review