镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

feat(dedupe): attribute records reviews to participating observations - #1145

Merged
kmbroai merged 3 commits into
mainfrom
codex/records-review-attribution
Oct 1, 2026
Merged

kmbroai merged 3 commits into
mainfrom
codex/records-review-attribution

Conversation

@kmbroai

@kmbroai kmbroai commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Records-mode review requests now identify the exact participating host observations, separating incoming beneficiaries from comparison-only context. Hosts can consume these identities without parsing prompts or inferring membership from final groups.

Changes

  • Carry structured participant IDs from screening and pair review, then map synthetic comparison IDs back to host observation IDs.
  • Add optional attribution metadata with version 1 and sorted, distinct beneficiary/context arrays. Every records-mode request supplies it; missing or unknown participants fail before host execution.
  • Preserve request UUIDs, configured models, review batching, JSON-RPC 2.0, records input/result v1, and saved-scan checkpoints.
  • Document host responsibilities and add portable synthetic fixtures, recovery checks, legacy-host compatibility, and real CLI pipe assertions.

Testing

  • Focused records, deduplication, workflow, and review-transport tests: 142 passed, 3 platform skips.
  • Four shared contract fixtures passed through the built CLI's JSON-RPC stdin/stdout boundary.
  • SDK build, plugin build, TypeScript checks, and formatting passed.
  • Full local SDK testing encountered unrelated failures; representative failures reproduce on unchanged main. The complete GitHub Actions node-ci workflow subsequently passed, including all required Linux, macOS, and Windows Node 22 checks.
  • Three independent native local review passes and a fresh verifier found no actionable regressions; the immutable-head publication receipt passed.

Risk and rollout

The metadata is additive and older hosts can ignore it. Hosts requiring attribution should validate and persist it with the request UUID before provisioning execution. This change adds no accounting logic, command, model producer, checkpoint behavior, release, or deployment. Synthetic protocol tests do not establish live host/backend integration.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the enhancement New feature or request label Oct 1, 2026
@kmbroai
kmbroai marked this pull request as ready for review October 1, 2026 18:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T18:36:53.125996Z 1403d91 Manual request
🔒 Security Review ✅ Completed 2026-10-01T19:07:37.239785Z 4199029 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kmbroai

kmbroai commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1403d91a3d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/docs/dedupe-records.md Resolved

@soyeon-oai soyeon-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at 1403d91. I traced participant IDs through screening and pair scheduling, host-ID mapping, and JSON-RPC serialization. The beneficiary/context split matches invocation anchor membership, invalid attribution fails before host execution, and saved-scan checkpoint behavior remains unchanged.

I verified the successful hosted CI run, including the records attribution, retry, compatibility, and real CLI pipe tests. The existing documentation formatting nit is nonblocking. This was source and hosted-CI review; I did not independently run tests or validate live host/backend integration.

@kmbroai
kmbroai merged commit 9329e47 into main Oct 1, 2026
56 checks passed
@kmbroai
kmbroai deleted the codex/records-review-attribution branch October 1, 2026 21:02
@github-actions github-actions Bot mentioned this pull request Oct 1, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants