Repository navigation
ci: smoke test published npm installs across supported platforms - #1129
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
soyeon-oai
left a comment
There was a problem hiding this comment.
Reviewed the consumer isolation, installed-version assertions, cross-platform launchers, and shared npm lookup. No actionable findings. Inspected the successful hosted smoke jobs, including Windows/macOS logs; I did not independently run tests.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow and smoke checks are consistent with existing packaging behavior and contain no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds daily, cross-platform validation of the latest published npm package.
Changes:
- Adds Linux, macOS, and Windows smoke-test workflow coverage.
- Verifies CLI, SDK, bundled Codex, and MCP startup.
- Extracts shared npm resolution and documents the workflow.
| File | Description |
|---|---|
.github/workflows/published-install-smoke.yml |
Defines the scheduled platform matrix. |
RELEASING.md |
Documents operation and local reproduction. |
sdk/typescript/scripts/package-smoke-npm.mjs |
Provides shared npm resolution. |
sdk/typescript/scripts/smoke-package.mjs |
Uses the shared resolver. |
sdk/typescript/scripts/smoke-published-package.mjs |
Implements published-package verification. |
sdk/typescript/tests-ts/published-install-smoke.test.ts |
Covers CLI version and startup failures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Install
@openai/codex-security@latestfrom npm and check startup daily so installation failures remain visible after release. Existing package tests continue to check the archive built from each commit.Changes
Testing
Eight focused installation/timeout tests, SDK types/format, changed-file formatting, and diff checks passed.
A live npm install of published version 0.1.31 passed the CLI, SDK, Codex, and MCP checks on Linux Node 22 while the checkout was version 0.1.32.
Full local SDK runs encountered pre-existing host-layout and permission failures, also reproduced in the original checkout. Full hosted CI covers the supported environments.
Three independent native reviews and a fresh verification pass found no actionable regressions.
Risk and rollout
The workflow follows npm's current
latestpackage and dependency resolution. Registry outages or broken published dependencies can fail it independently of source changes. The checks perform local startup operations without scans or model API calls. Public CLI behavior is unchanged.Public disclosure review