Repository navigation
fix(Table): merge grouped headers across rows - #7240
GeoffroyS6868 wants to merge 1 commit into
Conversation
|
Client output of the apps in
Raw sizes
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Merging this PR will degrade performance by 11.83%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
commit: |
da4a9d7 to
a86f366
Compare
Linked issue
Resolves #5612
Type of change
Description
Tables with uneven column-group depths render empty placeholder cells above shallow headers. Resolve each placeholder chain to its real TanStack header and render that header once with the corresponding
rowspan. The original header context remains available to slots, sorting, and column metadata.Adds a three-level playground example and regression coverage for grouped headers, column visibility, ordering, pinning, and accessibility. Updates the existing
aria-sorttest to check the merged header.Merged headers change the positions and number of
<thead>cells. Custom CSS that targets header cells by row ornth-childmay need adjustment.Screenshots
Validation
pnpm exec vitest run --maxWorkers 2passes: 303 test files, 8,011 tests passed, and 6 skipped.pnpm run typecheckpasses for the library, Nuxt playground and documentation.Checklist