[10.0] Backport regex operand parentheses fix - #3928
Merged
Merged
Conversation
Use the patched Microsoft.Build.Tasks.Git dependency to unblock CI restore without suppressing NuGet audit warnings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #3927 (b123371) to
hotfix/10.0.4, addressing #3923 for EFCore.PG 10.0. The backport commit retains the source author and cherry-pick attribution.Preserves the merged implementation: precedence-aware parentheses for both regex operands, regex/concatenation precedence of 1000, JSON traversal handling with the CAST exception, unchanged constant/column/parameter regex patterns, and the six JSON-existence baseline updates. The only conflict resolution was placing the new
JsonQueryNpgsqlTestregression without importing newer, unrelated tests. No product-code adaptation or SDK manifest change was needed.Also updates the build-only
Microsoft.SourceLink.GitHubdependency from 10.0.200 to 10.0.303 in a separate commit, as requested, to resolve the transitiveMicrosoft.Build.Tasks.Gitadvisory (GHSA-23fw-v26w-5fgq) that blocked CI restore. No audit warnings are suppressed.Validation
Using .NET SDK 10.0.300 and the local PostgreSQL instance:
ToJsonregression and literal-options switch cases.JsonDomQueryTest,JsonPocoQueryTest,JsonQueryNpgsqlTest,StringTranslationsNpgsqlTest,NorthwindFunctionsQueryNpgsqlTest,ArrayArrayQueryTest,ArrayListQueryTest,FullTextSearchDbFunctionsNpgsqlTest): 988 passed, 10 existing skips, 0 failures. The substring filter also includesAdHocJsonQueryNpgsqlTest.dotnet build --configuration Debugsucceeded with 0 warnings and 0 errors, without the warning override; database-free unit tests had 489 passed, 6 existing skips, 0 failures.The database-backed runs preceded the SourceLink update and used the command-line-only
-p:WarningsNotAsErrors=NU1902override for the then-existing advisory. The dependency update removes that restore blocker.