镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

[10.0] Backport regex operand parentheses fix - #3928

Merged
roji merged 2 commits into
hotfix/10.0.4from
roji-regex-backport-10-0
Oct 4, 2026
Merged

roji merged 2 commits into
hotfix/10.0.4from
roji-regex-backport-10-0

Conversation

@roji

@roji roji commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Backports #3927 (b123371) to hotfix/10.0.4, addressing #3923 for EFCore.PG 10.0. The backport commit retains the source author and cherry-pick attribution.

Preserves the merged implementation: precedence-aware parentheses for both regex operands, regex/concatenation precedence of 1000, JSON traversal handling with the CAST exception, unchanged constant/column/parameter regex patterns, and the six JSON-existence baseline updates. The only conflict resolution was placing the new JsonQueryNpgsqlTest regression without importing newer, unrelated tests. No product-code adaptation or SDK manifest change was needed.

Also updates the build-only Microsoft.SourceLink.GitHub dependency from 10.0.200 to 10.0.303 in a separate commit, as requested, to resolve the transitive Microsoft.Build.Tasks.Git advisory (GHSA-23fw-v26w-5fgq) that blocked CI restore. No audit warnings are suppressed.

Validation

Using .NET SDK 10.0.300 and the local PostgreSQL instance:

  • Focused regex tests: 76 passed, including all 17 new regression cases. SQL assertions confirm server-side regex execution, including the ToJson regression and literal-options switch cases.
  • Related suites (JsonDomQueryTest, JsonPocoQueryTest, JsonQueryNpgsqlTest, StringTranslationsNpgsqlTest, NorthwindFunctionsQueryNpgsqlTest, ArrayArrayQueryTest, ArrayListQueryTest, FullTextSearchDbFunctionsNpgsqlTest): 988 passed, 10 existing skips, 0 failures. The substring filter also includes AdHocJsonQueryNpgsqlTest.
  • After the SourceLink update: dotnet build --configuration Debug succeeded with 0 warnings and 0 errors, without the warning override; database-free unit tests had 489 passed, 6 existing skips, 0 failures.

The database-backed runs preceded the SourceLink update and used the command-line-only -p:WarningsNotAsErrors=NU1902 override for the then-existing advisory. The dependency update removes that restore blocker.

roji and others added 2 commits October 4, 2026 11:44
Fixes #3923

(cherry picked from commit b123371)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the patched Microsoft.Build.Tasks.Git dependency to unblock CI restore without suppressing NuGet audit warnings.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@roji
roji merged commit 26aadb3 into hotfix/10.0.4 Oct 4, 2026
10 of 11 checks passed
@roji
roji deleted the roji-regex-backport-10-0 branch October 4, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant