Repository navigation
fix(h2): preserve transport errors and mismatch causes - #6176
Merged
Merged
Conversation
Signed-off-by: Steven <steven@ceriously.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6176 +/- ##
==========================================
+ Coverage 91.67% 91.68% +0.01%
==========================================
Files 113 113
Lines 44443 44449 +6
==========================================
+ Hits 40741 40751 +10
+ Misses 3702 3698 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Follow-up to #5816, which introduced HTTP/2 response Content-Length validation and the unconditional replacement of stream errors.
Rationale
When an HTTP/2 session fails after response headers arrive, the received body can be shorter than its Content-Length. The stream error handler currently replaces the transport failure with
UND_ERR_RES_CONTENT_LENGTH_MISMATCH, discarding the original error code, message, and stack.Changes
cause.