镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content
This repository was archived by the owner on May 13, 2019. It is now read-only.
This repository was archived by the owner on May 13, 2019. It is now read-only.

Test/processes that create files that aren't in temp directories #26

Description

@Trott

Find and eliminate tests/processes that create files that aren’t in temp directories or other expected places. (Example: make test-addons creates files in test/addons.)

/cc @thealphanerd

Activity

  1. changed the title [-]Test/processes that creat files that aren't in temp directories[/-] [+]Test/processes that create files that aren't in temp directories[/+] on Mar 18, 2016
  2. MylesBorins commented on Mar 18, 2016

    @MylesBorins
    Contributor

    I'm into helping on this one.

  3. Trott commented on Dec 21, 2017

    @Trott
    MemberAuthor

    Checked this in a rough way by running make test in one terminal window on macOS while running sudo fs_usage -w | grep node | egrep '\bopen\b' | grep W | grep -v /dev/ in another terminal window and then lots of manual review of the results. Number of problematic files found is fewer than I expected. PRs coming soon.

  4. Trott commented on Dec 21, 2017

    @Trott
    MemberAuthor
  5. Trott commented on Dec 21, 2017

    @Trott
    MemberAuthor
  6. Trott commented on Dec 21, 2017

    @Trott
    MemberAuthor

    nodejs/node#17811

    And that's the last of them, as far as I can tell. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions