镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Add brew install corepack for current / pending releases - #7120

Closed
karlhorky wants to merge 2 commits into
nodejs:mainfrom
karlhorky:patch-1
Closed

karlhorky wants to merge 2 commits into
nodejs:mainfrom
karlhorky:patch-1

Conversation

@karlhorky

@karlhorky karlhorky commented Oct 12, 2024 •

Copy link
Copy Markdown

Description

As reported in the issues below, Homebrew installation behavior is divergent with the latest releases and the older releases:

The short version is this:

  • brew install node@22: corepack not installed
  • brew install node@20 and older: corepack installed

Homebrew currently expects users to install Corepack separately with brew install corepack:

After this PR, brew install corepack is printed for releases with a .status of Current or Pending:

Node.js v22 (note the new line brew install corepack)

Screenshot 2024-10-12 at 18 19 14

Node.js v20

Screenshot 2024-10-12 at 18 18 56

Validation

Read into the issues above to validate the documented behavior of Homebrew.

Related Issues

Already linked above

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

cc @aduh95

@karlhorky
karlhorky requested a review from a team as a code owner October 12, 2024 16:12
@vercel

vercel Bot commented Oct 12, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 12, 2024 4:18pm

Comment thread apps/site/util/getNodeDownloadSnippet.ts Outdated
Signed-off-by: Karl Horky <karl.horky@gmail.com>
@avivkeller

Copy link
Copy Markdown
Member

Users may not need/want to install corepack, so maybe just add a comment that explains that corepack is not distributed with the bundle?

@ovflowd

ovflowd commented Oct 12, 2024

Copy link
Copy Markdown
Member

I'm not a fan that Homebrew is intentionally changing how Node is installed (https://github.com/Homebrew/homebrew-core/blob/master/Formula/n/node.rb#L68-L88) by building Node natively and intentionally removing features.

At the same time, I cannot endorse manual extra steps to be added on our side on the downloads page. This must be resolved on Heombrew's side, and I'll report there and ask them to please not change the expected way people expect Node to perform across environments.

Unfortunately I don't think this change should land here, and I would discourage this as a fix.

@karlhorky

Copy link
Copy Markdown
Author

Sounds good, understood and agreed that Homebrew's divergent behavior seems unexpected and incorrect.

Closing.

@karlhorky karlhorky closed this Oct 12, 2024
@karlhorky
karlhorky deleted the patch-1 branch October 12, 2024 19:42

This branch was successfully deployed

1 active deployment
Preview — e50356a5 Deployed Oct 12, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants