Repository navigation
doc: clarify hex code usage in styleText docs - #66539
Merged
Merged
Conversation
7 tasks done
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Chris Swithinbank <swithinbank@gmail.com>
jasnell
approved these changes
Oct 5, 2026
MoLow
approved these changes
Oct 6, 2026
Contributor
|
Please make sure you have read and understood the following documents: |
delucis
force-pushed
the
delucis/styletext-docs
branch
from
October 6, 2026 12:24
a55b721 to
0e04f32
Compare
Contributor
Author
|
Thanks for the guidance — I made the initial edit via the GitHub UI, so had to wait while travelling before I could clone locally to amend my commit message, apologies for that (the Node repo is not one to download on train WiFi 😅). I just force pushed the amended commit, which should now follow the required conventions. Just to confirm: no AI, no automation, 100% human mistakes, and I’m obviously happy to comply with the CoC and Developer Certificate of Origin. |
Collaborator
|
Landed in 04fb145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation of the
styleText()utility to better reflect support for hex code colors when combined with other modifiers.This is a follow-up to DefinitelyTyped/DefinitelyTyped#75656 where @Renegade334 pointed out that the canonical location for my docs changes would be in this repo.