Repository navigation
src: use native CopyArrayBufferBytes for webstream buffer copy - #66400
Merged
Merged
Conversation
Renegade334
commented
Sep 29, 2026
Comment on lines
+1675
to
+1677
| CHECK(args[0]->IsArrayBuffer()); | ||
| CHECK(args[1]->IsUint32()); | ||
| CHECK(args[2]->IsArrayBuffer() || args[2]->IsSharedArrayBuffer()); | ||
| CHECK(args[2]->IsArrayBuffer()); |
Member
Author
There was a problem hiding this comment.
SharedArrayBuffers could never make it down this path, as canCopyArrayBuffer() uses ArrayBuffer primordials which throw on SharedArrayBuffers.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66400 +/- ##
==========================================
+ Coverage 90.36% 90.37% +0.01%
==========================================
Files 792 792
Lines 275564 275562 -2
Branches 52832 52829 -3
==========================================
+ Hits 249016 249048 +32
+ Misses 16965 16920 -45
- Partials 9583 9594 +11
🚀 New features to boost your workflow:
|
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Renegade334
force-pushed
the
copyarraybuffer-native
branch
from
September 30, 2026 04:44
5769480 to
6b117f7
Compare
addaleax
approved these changes
Sep 30, 2026
Collaborator
Collaborator
|
Landed in a7e9f3b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the V8 API path for these, which performs its own bounds handling.
I'm not seeing any performance delta, but we may as well not reinvent the wheel.