Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66365 +/- ##
==========================================
- Coverage 90.36% 90.35% -0.02%
==========================================
Files 792 792
Lines 275398 275424 +26
Branches 52776 52779 +3
==========================================
- Hits 248877 248861 -16
- Misses 16937 16982 +45
+ Partials 9584 9581 -3 🚀 New features to boost your workflow:
|
MoLow
approved these changes
Sep 28, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
Commit Queue failedThe pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
Contributor
|
This pull request has conflicts with its base branch, removing the |
The C++ option parser treats `_` and `-` as the same character in option names, so `--watch_path` is the same as `--watch-path`. Watch mode compared spellings literally when it removed its own flags from `process.execArgv` and `NODE_OPTIONS` before spawning the child. The underscore spellings got through, so each child went back into watch mode and spawned another child, and the application never ran. Normalize option names before comparing them. Forward the original arguments to the child unchanged. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
trivikr
force-pushed
the
watch-underscore-aliases
branch
from
October 5, 2026 15:17
3ef07c5 to
0594e97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66364
The C++ option parser treats
_and-as the same character in option names, so--watch_pathis the same as--watch-path.Watch mode compared spellings literally when it removed its own flags from
process.execArgvandNODE_OPTIONSbefore spawning the child. The underscore spellings got through, so each child went back into watch mode and spawned another child, and the application never ran.Normalize option names before comparing them. Forward the original arguments to the child unchanged.
Assisted-by: claude:opus-5.5