http: align empty proxy env var handling with fetch() - #66210

# 371a26a772ba62d4e9bb07c7994aba62245fb0c5 ok 1 assisted-by-is-trailer: no Assisted-by metadata ok 2 co-authored-by-is-trailer: no Co-authored-by metadata ok 3 fixes-url: Valid fixes URL. [https://github.com/nodejs/node/issues/66202] ok 4 line-after-title: blank line after title ok 5 line-length: line-lengths are valid not ok 6 signed-off-by: Commit must have a "Signed-off-by" trailer () --- { found: '', compare: '===', wanted: '', at: { line: 0, column: 0, body: [ '', 'Use nullish coalescing (??) instead of logical OR (||) when selecting', 'between lower- and upper-cased proxy environment variables, matching', "the behavior already used by fetch()/Undici's EnvHttpProxyAgent.", '', 'Previously, an explicit empty string in a lower-cased variable', "(e.g. http_proxy='') would be treated as falsy and silently fall back", 'to the upper-cased variable in http.request(), while fetch() correctly', 'treated the empty string as an explicit override.', '', 'Fixes: https://github.com/nodejs/node/issues/66202' ] } } ... ok 7 subsystem: valid subsystems [http] ok 8 title-format: Title is formatted correctly. 0..8 # tests 8 # pass 7 # fail 1 # Please review the commit message guidelines: # https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines npm warn deprecated tap@16.3.10: Versions of tap before v18 are no longer maintained. Please upgrade. npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated libtap@1.4.1: This library is no longer used by node-tap, and is unmaintained. npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.