Repository navigation
doc: add print results for examples in WebStreams - #49143
Merged
nodejs-github-bot merged 2 commits intoAug 15, 2023
Merged
Conversation
aduh95
approved these changes
Aug 14, 2023
deokjinkim
approved these changes
Aug 14, 2023
lpinca
approved these changes
Aug 14, 2023
|
|
||
| for await (const chunk of transformedStream) | ||
| console.log(chunk); | ||
| // Prints A |
Member
There was a problem hiding this comment.
Suggested change
| // Prints A | |
| // Prints: A |
| (async () => { | ||
| for await (const chunk of transformedStream) | ||
| console.log(chunk); | ||
| // Prints A |
Member
There was a problem hiding this comment.
Suggested change
| // Prints A | |
| // Prints: A |
| const readable = Readable.from(dataArray); | ||
| const data = await arrayBuffer(readable); | ||
| console.log(`from readable: ${data.byteLength}`); | ||
| // Prints from readable: 76 |
Member
There was a problem hiding this comment.
Suggested change
| // Prints from readable: 76 | |
| // Prints: from readable: 76 |
| const readable = Readable.from(dataArray); | ||
| arrayBuffer(readable).then((data) => { | ||
| console.log(`from readable: ${data.byteLength}`); | ||
| // Prints from readable: 76 |
Member
There was a problem hiding this comment.
Suggested change
| // Prints from readable: 76 | |
| // Prints: from readable: 76 |
| const readable = dataBlob.stream(); | ||
| const data = await blob(readable); | ||
| console.log(`from readable: ${data.size}`); | ||
| // Prints from readable: 27 |
Member
There was a problem hiding this comment.
Suggested change
| // Prints from readable: 27 | |
| // Prints: from readable: 27 |
| const readable = Readable.from(dataBuffer); | ||
| buffer(readable).then((data) => { | ||
| console.log(`from readable: ${data.length}`); | ||
| // Prints from readable: 27 |
Member
There was a problem hiding this comment.
Suggested change
| // Prints from readable: 27 | |
| // Prints: from readable: 27 |
| const readable = Readable.from(JSON.stringify(items)); | ||
| const data = await json(readable); | ||
| console.log(`from readable: ${data.length}`); | ||
| // Prints from readable: 100 |
Member
There was a problem hiding this comment.
Suggested change
| // Prints from readable: 100 | |
| // Prints: from readable: 100 |
| const readable = Readable.from(JSON.stringify(items)); | ||
| json(readable).then((data) => { | ||
| console.log(`from readable: ${data.length}`); | ||
| // Prints from readable: 100 |
Member
There was a problem hiding this comment.
Suggested change
| // Prints from readable: 100 | |
| // Prints: from readable: 100 |
| const readable = Readable.from('Hello world from consumers!'); | ||
| const data = await text(readable); | ||
| console.log(`from readable: ${data.length}`); | ||
| // Prints from readable: 27 |
Member
There was a problem hiding this comment.
Suggested change
| // Prints from readable: 27 | |
| // Prints: from readable: 27 |
| const readable = Readable.from('Hello world from consumers!'); | ||
| text(readable).then((data) => { | ||
| console.log(`from readable: ${data.length}`); | ||
| // Prints from readable: 27 |
Member
There was a problem hiding this comment.
Suggested change
| // Prints from readable: 27 | |
| // Prints: from readable: 27 |
commented
Aug 14, 2023
Member
|
commented
Aug 15, 2023
Contributor
Author
|
@lpinca Hi, thank you for your opinion. |
deokjinkim
approved these changes
Aug 15, 2023
commented
Aug 15, 2023
Collaborator
|
Landed in 9a2e6bc |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with the other examples, I added something about the resulting output.(Only output results that do not change)