Repository navigation
lib: fix BroadcastChannel initialization location - #46864
Merged
nodejs-github-bot merged 1 commit intoMar 1, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
Collaborator
joyeecheung
approved these changes
Feb 28, 2023
anonrig
approved these changes
Feb 28, 2023
lpinca
approved these changes
Feb 28, 2023
legendecas
approved these changes
Mar 1, 2023
Collaborator
|
Landed in da0bc6d |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46864 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
commented
Apr 3, 2023
Contributor
|
@codebytere this broke the build when pulling into v18.x. Do you mind creating a backport PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs electron/electron#37417.
Refs #40532.
Refs electron/electron#37421.
Fixes a bug wherein
BroadcastChannelshould have been initialized inlib/internal/bootstrap/browser.jsinstead oflib/internal/bootstrap/node.js. That inadvertently made it such that there was incorrect handling of the DOM vs Node.js implementations ofBroadcastChannel.