镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

test: fixing broken test #28345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MelinaMejia95 wants to merge 1 commit into from
Closed

test: fixing broken test #28345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions test/parallel/test-readable-from.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const { Readable } = require('stream');
const { strictEqual } = require('assert');

async function toReadableBasicSupport() {
async function * generate() {
async function* generate() {
yield 'a';
yield 'b';
yield 'c';
Expand All @@ -22,7 +22,7 @@ async function toReadableBasicSupport() {
}

async function toReadableSyncIterator() {
function * generate() {
function* generate() {
yield 'a';
yield 'b';
yield 'c';
Expand Down Expand Up @@ -64,7 +64,7 @@ async function toReadableString() {
}

async function toReadableOnData() {
async function * generate() {
async function* generate() {
yield 'a';
yield 'b';
yield 'c';
Expand All @@ -86,7 +86,7 @@ async function toReadableOnData() {
}

async function toReadableOnDataNonObject() {
async function * generate() {
async function* generate() {
yield 'a';
yield 'b';
yield 'c';
Expand All @@ -109,24 +109,22 @@ async function toReadableOnDataNonObject() {
}

async function destroysTheStreamWhenThrowing() {
async function * generate() {
async function* generate() {
throw new Error('kaboom');
}

const stream = Readable.from(generate());

stream.read();

try {
await once(stream, 'error');
} catch (err) {
strictEqual(err.message, 'kaboom');
strictEqual(stream.destroyed, true);
}
const [err] = await once(stream, 'error');
strictEqual(err.message, 'kaboom');
strictEqual(stream.destroyed, true);

}

async function asTransformStream() {
async function * generate(stream) {
async function* generate(stream) {
for await (const chunk of stream) {
yield chunk.toUpperCase();
}
Expand Down