Repository navigation

test: fix flaky inspector-stop-profile-after-done - #18126

Closed

Trott wants to merge 25 commits into

nodejs:masterfrom

Trott:fix-flaky-inspector

Closed

test: fix flaky inspector-stop-profile-after-done#18126
Trott wants to merge 25 commits into
nodejs:masterfrom
Trott:fix-flaky-inspector

Commits on Mar 2, 2018
- wip: fix flaky inspector-stop-profile-after-done
  Trott
  committed
  7e6ce28
- wip: throw rather than timeout on infinite loop
  Trott
  committed
  6eb2a64
- assert-o-rama
  Trott
  committed
  fa0be69
- reduce test to basically nothing
  Trott
  committed
  7f6e390
- wip: add session
  Trott
  committed
  7435ae2
- wip: add an await
  Trott
  committed
  beb87c3
- add another await
  Trott
  committed
  f934fb1
- a third await
  Trott
  committed
  b2c0fb2
- wip: send four command
  Trott
  committed
  9838d7f
- wip: reduce messages to 1
  Trott
  committed
  20a565c
- wip: 2 sends
  Trott
  committed
  99f7d51
- wip: 3 sends
  Trott
  committed
  02fcc81
- wip: is it better if we await the whole debugger-attach thing?
  Trott
  committed
  4c6c788
- all four sends
  Trott
  committed
  4d3f4c8
- wip: 3 sends but still waiting for debugger disconnect message
  Trott
  committed
  c57df84
- try moving Profiler.start
  Trott
  committed
  be6a7f1
- see if moving Profiler.start after program exits still has flaky results or not
  Trott
  committed
  053d19e
- add an await
  Trott
  committed
  63ad338
- no reason to think this will go any better but why not?
  Trott
  committed
  aff6d01
- try writing to the process to let it know when to end
  Trott
  committed
  37748aa
- remove profiler to see if that fixes it
  Trott
  committed
  9b9abc6
- try longer times
  Trott
  committed
  7143464
- doubling all the times: makes it worse or better or neither?
  Trott
  committed
  818e16f
- increase times some more as it seems to enhance stability
  Trott
  committed
  ecd18cf
- increase timeouts
  Trott
  committed
  e259d26

Commits

Commits on Mar 2, 2018