Repository navigation
Conversation
Every npm version bump requires a few patches to be floated on node-gyp for io.js compatibility. These patches are found in 03d1992, 5de334c, and da730c7. This commit squashes them into a single commit. PR-URL: nodejs#990 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
On Windows, when node or io.js attempts to dynamically load a compiled addon, the compiled addon tries to load node.exe or iojs.exe again - depending on which import library the module used when it was linked. This makes it impossible to rename node.exe or iojs.exe, because when that happens the module can't find its dependencies. With this patch, a delay-load hook is added to all modules that are compiled with node-gyp. The delay-load hook ensures that whenever a module tries to load imports from node.exe/iojs.exe, it'll just refer back to the process image, thus making it possible to rename the iojs/node binary. Bug: nodejs#751 Bug: nodejs#965 Upstream PR: nodejs/node-gyp#599 PR-URL: nodejs#1251 Reviewed-By: Rod Vagg <rod@vagg.org>
The delay-load hook that was landed in 3d46fef to make compiled addons work on Windows regardless of the iojs.exe/node.exe filename causes issues with a small amount of compiled addons. Therefore this patch makes it an opt-in feature. An addon may set the 'win_delay_load_hook' option to 'true' in its binding.gyp to enable this feature. Example: ``` { 'targets': [ { 'target_name': 'ernie', 'win_delay_load_hook': 'true', ... ``` Refs: nodejs#1251 PR-URL: nodejs#1266 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
There was a problem hiding this comment.
Just curious, why are the email links encoded like this, and why does it change each update? o.0
|
I always wonder why do you keep hardcoded version in all these .html files. |
|
Looked over the code. Can't wait for npm@3 to reduce some of those Also, yay no whitespace errors this time. :) I'm pretty sure @piscisaureus's commits can be rolled into one second floating patch.
LGTM otherwise. |
|
@YuriSolovyov the HTML documentation is primarily meant to be used by Windows users who don't have access to |
|
@Fishrock123 The email links are randomly encoded to mitigate spam, and date from a quaint time when people thought that was possible. |
|
Ah. Running the tests again now, hopefully github survives. |
|
Tests seem fine, LGTM pending a potential squash on @piscisaureus's commits, but that isn't of too much concern. |
|
I'd still like a thumbs up from @piscisaureus before merging. I'll probably combine his two commits, if he says that's OK. |
|
@othiym23 still, that would make diffs a lot less noisy and short |
|
Landed in iojs:73de135...iojs:ba93c58 |
|
|
|
@piscisaureus f166cde is missing its commit message and associated metadata. @chrisdickinson made the call that it wasn't worth changing because there are commits after it, but we should probably avoid that sort of thing in the future. |
This release is mostly bug fixes, including:
fe1bc38#7672
npm-registry-client@3.1.2:Fix client-side certificate handling by correcting property name.
(@atamon)
89ce829#7630
hosted-git-info@1.5.3: Part3 of ensuring that GitHub shorthand is handled consistently.
(@othiym23)
63313eb#7630
realize-package-specifier@2.2.0: Part 2 of ensuring that GitHub shorthandis handled consistently. (@othiym23)
3ed41bf#7630
npm-package-arg@3.1.1: Part1 of ensuring that GitHub shorthand is handled consistently.
(@othiym23)
I've applied @cjihrig's
node-gypfloating patch, as well as reapplying @piscisaureus's two patches for delayed loading of compiled modules. Are both of those commits necessary? Can they be combined into a single commit? I'm in the process of setting up a quilt to handle these floating patches (which I am still hopeful will only be needed for a little while), but the commit logs are going to start getting noisy if the list of commits that come along for the ride with each new version of npm continues to grow.R: @piscisaureus
R: @rvagg
R: @Fishrock123