Generators in REPL can't be specified using function *gen() {} #9850

Activity

1. mscdex

   added

   replIssues and PRs related to the REPL subsystem.Issues and PRs related to the REPL subsystem.

   on Nov 30, 2016
2. not-an-aardvark

   added

   confirmed-bugIssues and PRs for confirmed bugs.Issues and PRs for confirmed bugs.

   on Nov 30, 2016
3. not-an-aardvark commented on Nov 30, 2016

   

   not-an-aardvark

   on Nov 30, 2016

   Contributor

   More actions

   It looks like this affects v6+, but not v4.
4. not-an-aardvark

   self-assigned this

   on Nov 30, 2016
5. princejwesley commented on Nov 30, 2016

   

   princejwesley

   on Nov 30, 2016

   Contributor

   More actions

   @not-an-aardvark its a preprocess issue

   👍React with 👍2Reacted by Teddy Katz and Mauro Gabriel Titimoli
6. princejwesley commented on Nov 30, 2016

   

   princejwesley

   on Nov 30, 2016

   Last edited by Fishrock123

   Contributor

   More actions

   @not-an-aardvark this may help

   node 🙈 ₹ git:(upstream ⚡ repl.9743)  git diff
   diff --git a/lib/repl.js b/lib/repl.js
   index 70428ce..ff37cfb 100644
   --- a/lib/repl.js
   +++ b/lib/repl.js
   @@ -249,8 +249,8 @@ function REPLServer(prompt,
          self.wrappedCmd = true;
        } else {
          // Mitigate https://github.com/nodejs/node/issues/548
   -      cmd = cmd.replace(/^\s*function\s+([^(]+)/,
   -                (_, name) => `var ${name} = function ${name}`);
   +      cmd = cmd.replace(/^\s*function(\s+(?:\*\s*)?|\*\s+)([^(]+)/,
   +                (_, gen, name) => `var ${name} = function${gen}${name}`);
        }
        // Append a \n so that it will be either
        // terminated, or continued onto the next expression if it's an
   node 🙈 ₹ git:(upstream ⚡ repl.9743) 
   
7. not-an-aardvark commented on Nov 30, 2016

   

   not-an-aardvark

   on Nov 30, 2016

   Contributor

   More actions

   @princejwesley Thanks, that's very helpful. However, I think your diff fails with:

   function*foo() {}

   because whitespace is not required before/after a generator star.

   I think I have a fix; I'll make a PR shortly.
8. princejwesley commented on Nov 30, 2016

   

   princejwesley

   on Nov 30, 2016

   Contributor

   More actions

   @not-an-aardvark Remember to land your PR after this
9. not-an-aardvark commented on Nov 30, 2016

   

   not-an-aardvark

   on Nov 30, 2016

   Last edited by not-an-aardvark

   Contributor

   More actions

   While fixing this, I noticed another bug:

   function foo() {} foo()

   This is a SyntaxError in the REPL, but it's valid JS. It occurs because it gets preprocessed to

   var foo = function foo() {} foo()

   ...which is a syntax error.

   To fix this, we need to put a semicolon after the var foo = function foo() {} declaration. I'll add another commit to the PR.
10. princejwesley commented on Nov 30, 2016

    

    princejwesley

    on Nov 30, 2016

    Contributor

    More actions

    @not-an-aardvark User input can be a partial/multi-line function. We can't insert semicolon here. Here is one more edge case
11. not-an-aardvark commented on Nov 30, 2016

    

    not-an-aardvark

    on Nov 30, 2016

    Contributor

    More actions

    Ah, good point. Okay, I'll just submit the PR with the generator function fix then.

    👍React with 👍1Reacted by Mauro Gabriel Titimoli
12. not-an-aardvark

    closed this as completedin #9852on Dec 2, 2016
13. addaleax

    added a commit that references this issue on Dec 5, 2016

    repl: fix generator function preprocessing

    ...

    9099664
14. jmdarling

    added a commit that references this issue on Dec 8, 2016

    repl: fix generator function preprocessing

    ...

    8a7a0ef
15. MylesBorins

    added 2 commits that reference this issue on Dec 20, 2016

    repl: fix generator function preprocessing

    ...

    eba4f9a

    repl: fix generator function preprocessing

    ...

    bfc9454